Skip to content

[CI][NFC] Rename inputs.check_filters -> inputs.changes #10505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[CI][NFC] Rename inputs.check_filters -> inputs.changes #10505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/sycl_linux_build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ on:
type: string
required: false
default: 'SYCL-2020'
check_filters:
changes:
type: string
description: 'Filter matches for the changed files in the PR'
default: '[llvm, clang, sycl, llvm_spirv, xptifw, libclc, libdevice]'
Expand Down Expand Up @@ -136,35 +136,35 @@ jobs:
id: build
run: cmake --build $GITHUB_WORKSPACE/build
- name: check-llvm
if: always() && !cancelled() && contains(inputs.check_filters, 'llvm')
if: always() && !cancelled() && contains(inputs.changes, 'llvm')
run: |
cmake --build $GITHUB_WORKSPACE/build --target check-llvm
- name: check-clang
if: always() && !cancelled() && contains(inputs.check_filters, 'clang')
if: always() && !cancelled() && contains(inputs.changes, 'clang')
run: |
# Can we move this to Dockerfile? Hopefully, noop on Windows.
export XDG_CACHE_HOME=$GITHUB_WORKSPACE/os_cache
cmake --build $GITHUB_WORKSPACE/build --target check-clang
- name: check-sycl
if: always() && !cancelled() && contains(inputs.check_filters, 'sycl')
if: always() && !cancelled() && contains(inputs.changes, 'sycl')
run: |
# TODO consider moving this to Dockerfile.
export LD_LIBRARY_PATH=/usr/local/cuda/compat/:/usr/local/cuda/lib64:$LD_LIBRARY_PATH
cmake --build $GITHUB_WORKSPACE/build --target check-sycl
- name: check-llvm-spirv
if: always() && !cancelled() && contains(inputs.check_filters, 'llvm_spirv')
if: always() && !cancelled() && contains(inputs.changes, 'llvm_spirv')
run: |
cmake --build $GITHUB_WORKSPACE/build --target check-llvm-spirv
- name: check-xptifw
if: always() && !cancelled() && contains(inputs.check_filters, 'xptifw')
if: always() && !cancelled() && contains(inputs.changes, 'xptifw')
run: |
cmake --build $GITHUB_WORKSPACE/build --target check-xptifw
- name: check-libclc
if: always() && !cancelled() && contains(inputs.check_filters, 'libclc')
if: always() && !cancelled() && contains(inputs.changes, 'libclc')
run: |
cmake --build $GITHUB_WORKSPACE/build --target check-libclc
- name: check-libdevice
if: always() && !cancelled() && contains(inputs.check_filters, 'libdevice')
if: always() && !cancelled() && contains(inputs.changes, 'libdevice')
run: |
cmake --build $GITHUB_WORKSPACE/build --target check-libdevice
- name: Install
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sycl_precommit_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,4 +92,4 @@ jobs:
build_cache_suffix: "default"
lts_matrix: ${{ needs.test_matrix.outputs.lts_lx_matrix }}
lts_aws_matrix: ${{ needs.test_matrix.outputs.lts_aws_matrix }}
check_filters: ${{ needs.detect_changes.outputs.filters }}
changes: ${{ needs.detect_changes.outputs.filters }}
2 changes: 1 addition & 1 deletion .github/workflows/sycl_precommit_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,4 @@ jobs:
with:
lts_matrix: ${{ needs.test_matrix.outputs.lts_wn_matrix }}
build_ref: ${{ github.event.pull_request.head.sha }}
check_filters: ${{ needs.detect_changes.outputs.filters }}
changes: ${{ needs.detect_changes.outputs.filters }}
14 changes: 7 additions & 7 deletions .github/workflows/sycl_windows_build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ on:
type: string
required: false
default: ""
check_filters:
changes:
type: string
description: 'Filter matches for the changed files in the PR'
default: '[llvm, clang, sycl, llvm_spirv, xptifw, libclc, libdevice]'
Expand Down Expand Up @@ -77,27 +77,27 @@ jobs:
run: |
cmake --build build --target sycl-toolchain
- name: check-llvm
if: always() && !cancelled() && contains(inputs.check_filters, 'llvm')
if: always() && !cancelled() && contains(inputs.changes, 'llvm')
run: |
cmake --build build --target check-llvm
- name: check-clang
if: always() && !cancelled() && contains(inputs.check_filters, 'clang')
if: always() && !cancelled() && contains(inputs.changes, 'clang')
run: |
cmake --build build --target check-clang
- name: check-sycl
if: always() && !cancelled() && contains(inputs.check_filters, 'sycl')
if: always() && !cancelled() && contains(inputs.changes, 'sycl')
run: |
cmake --build build --target check-sycl
- name: check-llvm-spirv
if: always() && !cancelled() && contains(inputs.check_filters, 'llvm_spirv')
if: always() && !cancelled() && contains(inputs.changes, 'llvm_spirv')
run: |
cmake --build build --target check-llvm-spirv
- name: check-xptifw
if: always() && !cancelled() && contains(inputs.check_filters, 'xptifw')
if: always() && !cancelled() && contains(inputs.changes, 'xptifw')
run: |
cmake --build build --target check-xptifw
- name: check-libdevice
if: always() && !cancelled() && contains(inputs.check_filters, 'libdevice')
if: always() && !cancelled() && contains(inputs.changes, 'libdevice')
run: |
cmake --build build --target check-libdevice
- name: Install
Expand Down