Skip to content

[SYCL][ESIMD] Deprecate ESIMD Emulator #10506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildbot/configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def main():
parser.add_argument("--hip-platform", type=str, choices=['AMD', 'NVIDIA'], default='AMD', help="choose hardware platform for HIP backend")
parser.add_argument("--host-target", default='X86',
help="host LLVM target architecture, defaults to X86, multiple targets may be provided as a semi-colon separated string")
parser.add_argument("--enable-esimd-emulator", action='store_true', help="build with ESIMD emulation support")
parser.add_argument("--enable-esimd-emulator", action='store_true', help="build with ESIMD emulation support (deprecated)")
parser.add_argument("--enable-all-llvm-targets", action='store_true', help="build compiler with all supported targets, it doesn't change runtime build")
parser.add_argument("--no-assertions", action='store_true', help="build without assertions")
parser.add_argument("--docs", action='store_true', help="build Doxygen documentation")
Expand Down
2 changes: 1 addition & 1 deletion sycl/doc/EnvironmentVariables.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ The value of this environment variable is a comma separated list of filters, whe
- `opencl`
- `cuda`
- `hip`
- `esimd_emulator`
- `esimd_emulator` (Deprecated)
- `*`

Possible values of `device_type` are:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Please see the additional resources on the Intel DPC++ project's github:

1) [ESIMD Extension Specification](./sycl_ext_intel_esimd.md)
1) [ESIMD API/doxygen reference](https://intel.github.io/llvm-docs/doxygen/group__sycl__esimd.html)
1) [ESIMD Emulator](./sycl_ext_intel_esimd_emulator.md)
1) [ESIMD Emulator](./sycl_ext_intel_esimd_emulator.md) (deprecated)
1) [Examples](./examples/README.md)
1) [ESIMD end-to-end LIT tests](https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/ESIMD/)
1) [Implementation and API Restrictions](./sycl_ext_intel_esimd.md#implementation-restrictions)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

## Other content:
* [ESIMD API/doxygen reference](https://intel.github.io/llvm-docs/doxygen/group__sycl__esimd.html)
* [ESIMD Emulator](./sycl_ext_intel_esimd_emulator.md)
* [ESIMD Emulator](./sycl_ext_intel_esimd_emulator.md) (deprecated)
* [Examples](./examples/README.md)
* [ESIMD LIT tests - working code examples](https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/ESIMD/)

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# ESIMD kernel execution emulation on host.

## Deprecation note

ESIMD Emulator feature is deprecated and will be removed in the future.

## Introduction

ESIMD implementation provides a feature to execute ESIMD kernels on the host
Expand Down
4 changes: 4 additions & 0 deletions sycl/plugins/esimd_emulator/pi_esimd_emulator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2226,6 +2226,10 @@ pi_result piPluginInit(pi_plugin *PluginInit) {
return PI_ERROR_INVALID_VALUE;
}

std::cout
<< "WARNING: The ESIMD Emulator is deprecated and will be removed in the "
"future.\n";

// Check that the major version matches in PiVersion and SupportedVersion
_PI_PLUGIN_VERSION_CHECK(PluginInit->PiVersion, SupportedVersion);

Expand Down