Skip to content

[SYCL][Doc] Bindless images proposal name fix #10520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2023
Merged

[SYCL][Doc] Bindless images proposal name fix #10520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions sycl/doc/extensions/proposed/sycl_ext_oneapi_bindless_images.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,25 +648,25 @@ struct bindless_image_sampler {
sycl::addressing_mode addressing;
sycl::coordinate_normalization_mode coordinate;
sycl::filtering_mode filtering;
sycl::filtering_mode mipmapFiltering;
float minMipmapLevelClamp;
float maxMipmapLevelClamp;
float maxAnisotropy;
sycl::filtering_mode mipmap_filtering;
float min_mipmap_level_clamp;
float max_mipmap_level_clamp;
float max_anisotropy;
};

}
```

`mipmapFiltering` dictates the method in which sampling between mipmap
`mipmap_filtering` dictates the method in which sampling between mipmap
levels is performed.

`minMipmapLevelClamp` defines the minimum mipmap level from which we can sample,
with the minimum value being 0.
`min_mipmap_level_clamp` defines the minimum mipmap level from which we can
sample, with the minimum value being 0.

`maxMipmapLevelClamp` defines the maximum mipmap level from which we can sample.
This cannot value cannot be higher than the number of allocated levels.
`max_mipmap_level_clamp` defines the maximum mipmap level from which we can
sample. This cannot value cannot be higher than the number of allocated levels.

`maxAnisotropy` dictates the anisotropic ratio used when samplling the mipmap
`max_anisotropy` dictates the anisotropic ratio used when samplling the mipmap
with anisotropic filtering.

=== Explicit copies
Expand Down Expand Up @@ -1970,4 +1970,5 @@ These features still need to be handled:
Semantics.

- Updated code samples.
|4.1|2023-07-21| - Made bindless image sampler member names snake-case
|======================