[SYCL][NATIVECPU] Refactor from PI plugin to UR adapter #10523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urInit and urTeardown where in platform.cpp, refactored to a more relevant file runtime.cpp Fixed the format of CmakeLists (broken due to autoformatting) Refactored context Device as _device to have mor consistent naming.
…. Minor formatting issues. Removed unnecessary empty lines Removed comments that are no longer fitting
Moved from unique pointer to new for consistency with the whole API.
Removed misplaced #pragma once
- Added missing TODOs - Fixed slightly misleading comments
uwedolinsky
approved these changes
Jul 24, 2023
jandres742
reviewed
Jul 26, 2023
|
Minor comment above. Looks good. |
jandres742
approved these changes
Jul 26, 2023
kbenzie
approved these changes
Jul 26, 2023
|
Hello @intel/llvm-gatekeepers, we think this PR is ready to be merged. Thanks |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
This PR refactors the current SYCL Native CPU Implementation as a Unified Runtime adapter. No new functionalities are added. Contents of this PR: - Native CPU implementation divided in multiple source files at `sycl/plugins/unified_runtime/ur/adapters/native_cpu` - Native CPU PI plugin is now implemented through the `pi2ur.hpp` interface - _pi_* classes have now an equivalent ur_* class - `UR_PLATFORM_BACKEND_NATIVE_CPU` value added to `ur2piPlatformInfoValue`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the current SYCL Native CPU Implementation as a Unified Runtime adapter.
No new functionalities are added.
Contents of this PR:
sycl/plugins/unified_runtime/ur/adapters/native_cpupi2ur.hppinterfaceUR_PLATFORM_BACKEND_NATIVE_CPUvalue added tour2piPlatformInfoValue