[SYCL][UR] Fix device partition queries (2)

[jandres742]

Fix CSLICE partitioning for PVC.

Also, fix level_zero_ext_intel_cslice to correctly test with
and without immediate command list.

Signed-off-by: Jaime Arteaga [email protected]
Signed-off-by: Piotr Balcer [email protected]
Signed-off-by: Fábio Mestre [email protected]

[aelovikov-intel]

Test change LGTM.

[smaslov-intel]

what does it mean to return "0" value? why is this a literal "0" and not some enum value?

[pbalcer]

UR_DEVICE_PARTITION_BY_CSLICE does not have a value in the corresponding UR union type (or, maybe more accurately, its value is empty). Because the PI's data is as an array of key-value pairs, there's no way to represent an absence of value for a key. That's why the 0 assignment is here, which matches the old behavior.

[pbalcer]

👍
This restores the old behavior, but we might want to later revisit the level-zero adapter implementation so that it doesn't hardcode the partition type in the get info method.

[jandres742]

@intel/llvm-gatekeepers please merge when possible.

[aelovikov-intel]

@jandres742 , post-commit seems to be failing after this: https://github.com/intel/llvm/actions/runs/5731890807/job/15533756331

[jandres742]

@jandres742 , post-commit seems to be failing after this: https://github.com/intel/llvm/actions/runs/5731890807/job/15533756331

thanks @aelovikov-intel . checking.

[jandres742]

@jandres742 , post-commit seems to be failing after this: https://github.com/intel/llvm/actions/runs/5731890807/job/15533756331

thanks @aelovikov-intel . checking.

@aelovikov-intel : posted fix on #10649

[jandres742]

@aelovikov-intel seems like post build is still failing, but logs show something unrelated to these changes

https://github.com/intel/llvm/actions/runs/5736337996/job/15545731350

/__w/llvm/llvm/src/sycl/source/detail/builtins_relational.cpp:461:62: error: all paths through this function will call itself [-Werror,-Winfinite-recursion]
  461 | __SYCL_EXPORT s::cl_int __vSignBitSet(s::cl_float x) __NOEXC {
      |   

what do you advise?

[aelovikov-intel]

what do you advise?

We expect #10652 to fix it.