[SYCL] Stop throwing exception when passing empty accessor to handler::require() #10597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re(). Signed-off-by: Maronas, Marcos <[email protected]>
Signed-off-by: Maronas, Marcos <[email protected]>
Signed-off-by: Maronas, Marcos <[email protected]>
Signed-off-by: Maronas, Marcos <[email protected]>
| @@ -818,20 +818,18 @@ int main() { | |||
| } | |||
| } | |||
|
|
|||
| // SYCL2020 4.9.4.1: calling require() on empty accessor should throw | |||
| // SYCL2020 4.9.4.1: calling require() on empty accessor should not throw. | |||
There was a problem hiding this comment.
I'm confused. This is exactly wrong. The spec at 4.9.4.1 table 131 first entry says:
Throws exception with the
errc::invalid error code if
(acc.empty() == true).
There was a problem hiding this comment.
https://github.com/KhronosGroup/SYCL-Docs/pull/434/files in this PR, it was updated to say it's allowed.
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…::require() (intel#10597) According to the changes made in https://github.com/KhronosGroup/SYCL-Docs/pull/434/files, empty accessors can now be passed to `handler::require()` without throwing. --------- Signed-off-by: Maronas, Marcos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the changes made in https://github.com/KhronosGroup/SYCL-Docs/pull/434/files, empty accessors can now be passed to
handler::require()without throwing.