Skip to content

[SYCL][ESIMD] Move BFN function from experimental namespace #10606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 31, 2023
Merged

[SYCL][ESIMD] Move BFN function from experimental namespace #10606

merged 5 commits into from
Jul 31, 2023

Conversation

turinevgeny
Copy link
Contributor

No description provided.

@turinevgeny turinevgeny requested a review from a team as a code owner July 28, 2023 05:38
@turinevgeny
Copy link
Contributor Author

I have not found a good way to not replicate the operators for bfn_t enum in non-experimental namespace, if you have an idea, please let me know.

@turinevgeny turinevgeny temporarily deployed to aws July 28, 2023 05:53 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws July 28, 2023 06:31 — with GitHub Actions Inactive
@v-klochkov
Copy link
Contributor

I have not found a good way to not replicate the operators for bfn_t enum in non-experimental namespace, if you have an idea, please let me know.

Can you do it the same way as it was done here?
{code}
using argument_type
__SYCL_DEPRECATED("use sycl::ext::intel::esimd::xmx::dpas_argument_type") =
__ESIMD_NS::xmx::dpas_argument_type;
{code}

See 91e8364#diff-8040cee0a7937fbdfbdb85880bdf2873b7405fad4b20a0edff46a94dd4c6219d

@turinevgeny
Copy link
Contributor Author

I have not found a good way to not replicate the operators for bfn_t enum in non-experimental namespace, if you have an idea, please let me know.

Can you do it the same way as it was done here? {code} using argument_type __SYCL_DEPRECATED("use sycl::ext::intel::esimd::xmx::dpas_argument_type") = __ESIMD_NS::xmx::dpas_argument_type; {code}

See 91e8364#diff-8040cee0a7937fbdfbdb85880bdf2873b7405fad4b20a0edff46a94dd4c6219d

That works, thanks!

v-klochkov
v-klochkov reviewed Jul 28, 2023
View reviewed changes
@turinevgeny turinevgeny temporarily deployed to aws July 28, 2023 19:50 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws July 28, 2023 20:23 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws July 28, 2023 21:02 — with GitHub Actions Inactive
@v-klochkov
Copy link
Contributor

@turinevgeny please resolve the conflicts with head.

@turinevgeny
Copy link
Contributor Author

@turinevgeny please resolve the conflicts with head.

Done.

@turinevgeny turinevgeny temporarily deployed to aws July 29, 2023 01:50 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws July 29, 2023 02:29 — with GitHub Actions Inactive
@v-klochkov v-klochkov merged commit c9da5c7 into intel:sycl Jul 31, 2023
@turinevgeny turinevgeny deleted the MoveBFNFromExperimental branch July 31, 2023 17:52
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
@turinevgeny @mdtoguchi
[SYCL][ESIMD] Move BFN function from experimental namespace (intel#10606
b31ef91 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turinevgeny @v-klochkov