[SYCL] Use qualified name of template function call #1062
Conversation
|
Ping. |
|
I will update the review with the test requested |
sycl/include/CL/sycl/detail/pi.hpp
Outdated
| // Usage: | ||
| // Operator() - Call, Trace and Get result | ||
| // Use Macro PI_CALL_NOCHECK call the constructor directly. | ||
| template <typename FnType, size_t FnOffset> class CallPi { |
There was a problem hiding this comment.
I don't fully understand why these changes are present in the diff, is it a result of not fully correct merge from sycl branch?
sycl/test/regression/print_args.cpp
Outdated
| template <typename TArg0, typename... TArgs> | ||
| auto printArgs(TArg0 arg, TArgs... args) | ||
| { | ||
| //std::cout << 42 << std::endl; |
There was a problem hiding this comment.
I suggest to either uncomment this line or to completely remove it
|
@smaslov-intel, could you address review comments, please? |
smaslov-intel
force-pushed
the
adl
branch
4 times, most recently
from
af54139 to
0b0cd82
Compare
|
Sorry that it took ages to do this simple change. I think it is ready now. |
|
@smaslov-intel, the added regression test is empty. Could you upload the content of the test, please? |
Signed-off-by: Sergey V Maslov <[email protected]>
|
With ADL it seems we can look up for functions in the local scope and in the scope of the arguments. |
This is to fix #1011.
The reason for name conflict is ADL (https://en.cppreference.com/w/cpp/language/adl)
The only reliable way to fix this is to use qualified name.
Signed-off-by: Sergey V Maslov [email protected]