Skip to content

[SYCL][libdevice] Add max/min for all types to dl specific file #10625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

[SYCL][libdevice] Add max/min for all types to dl specific file #10625

merged 1 commit into from
Jul 31, 2023

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Jul 31, 2023 •
edited
Loading

DL framework developers require max/min functions for all data types, this PR group these required functions with other dl required functions which are located in imf_fp32/64_dl.cpp file.

@jinge90 jinge90 requested a review from a team as a code owner July 31, 2023 06:19
@jinge90 jinge90 requested a review from bso-intel July 31, 2023 06:19
@jinge90 jinge90 temporarily deployed to aws July 31, 2023 06:25 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to aws July 31, 2023 07:05 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 31, 2023

SYCL :: USM/memops2d/copy2d_device_to_device.cpp failed for AMD GPU, it should be a fake failure since libdevice doesn't impact AMD target.
Thanks very much.

@jinge90 jinge90 requested a review from a team July 31, 2023 23:04
@jinge90
Copy link
Contributor Author

jinge90 commented Jul 31, 2023

Hi, @intel/llvm-gatekeepers
Could you help review and merge this patch?
Thanks very much.

@aelovikov-intel
Copy link
Contributor

SYCL :: USM/memops2d/copy2d_device_to_device.cpp failed for AMD GPU, it should be a fake failure since libdevice doesn't impact AMD target. Thanks very much.

Failed like this:

FAIL: SYCL :: USM/memops2d/copy2d_device_to_device.cpp (1510 of 1566)
...
$ "env" "ONEAPI_DEVICE_SELECTOR=ext_oneapi_hip:gpu" "/__w/llvm/llvm/build-e2e/USM/memops2d/Output/copy2d_device_to_device.cpp.tmp.out"
# command stderr:
Memory access fault by GPU node-1 (Agent handle: 0x1ab5b10) on address 0x7fbede400000. Reason: Page not present or supervisor privilege.

error: command failed with exit status: -6

@intel/llvm-reviewers-cuda , does it look familiar?

@aelovikov-intel aelovikov-intel merged commit 3bd4e46 into intel:sycl Jul 31, 2023
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
@jinge90 @mdtoguchi
[SYCL][libdevice] Add max/min for all types to dl specific file (inte…
a3dfca6 
…l#10625)

DL framework developers require max/min functions for all data types,
this PR group these required functions with other dl required functions
which are located in imf_fp32/64_dl.cpp file.

Signed-off-by: jinge90 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bso-intel bso-intel bso-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinge90 @aelovikov-intel @bso-intel