[SYCL][LIBCLC] Fix identity values for (sub)group collectives min/max #10639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchlanda
force-pushed
the
jakub/libclc_maximum_minimum
branch
from
883d7ea to
f3da2d5
Compare
jchlanda
changed the title
Use +/- inf for minimum and maximum respectively. See: https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#table.identities for details.
jchlanda
force-pushed
the
jakub/libclc_maximum_minimum
branch
from
ca11107 to
4db5a0d
Compare
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…intel#10639) Use `+/-` `inf` for `minimum` and `maximum` respectively. See: https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#table.identities for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
+/-infforminimumandmaximumrespectively. See: https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#table.identities for details.