[SYCL] Fix execution graph cleanup on memory object destruction #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AGindinson
reviewed
Jan 30, 2020
sergey-semenov
force-pushed
the
cleanupfix
branch
2 times, most recently
from
ed7cc59 to
b9236af
Compare
sergey-semenov
force-pushed
the
cleanupfix
branch
2 times, most recently
from
5016154 to
8acbd77
Compare
The previous algorithm deleted a visited node if it had no dependencies left, but it only visited the immediate users of deleted nodes while leaving all potential indirect users unchanged. This resulted in leftover dependencies on dead memory objects. The new algorithm addresses this problem by traversing the entire graph component of the memory object being deleted instead. Signed-off-by: Sergey Semenov <[email protected]>
Signed-off-by: Sergey Semenov <[email protected]>
Signed-off-by: Sergey Semenov <[email protected]>
Signed-off-by: Sergey Semenov <[email protected]>
Signed-off-by: Sergey Semenov <[email protected]>
sergey-semenov
force-pushed
the
cleanupfix
branch
2 times, most recently
from
5830bfa to
932a8c9
Compare
romanovvlad
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous algorithm deleted a visited node if it had no dependencies
left, but it only visited the immediate users of deleted nodes while
leaving all potential indirect users unchanged. This resulted in
leftover dependencies on dead memory objects.
The new algorithm addresses this problem by traversing the entire graph
component of the memory object being deleted instead.
Signed-off-by: Sergey Semenov [email protected]