Skip to content

[SYCL][HIP] Initial HIP mem_advise implementation. #10697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jan 9, 2024
Merged

[SYCL][HIP] Initial HIP mem_advise implementation. #10697

merged 28 commits into from
Jan 9, 2024

Conversation

GeorgeWeb
Copy link
Contributor

@GeorgeWeb GeorgeWeb commented Aug 4, 2023 •
edited
Loading

Adds initial implementation for mem_advise to the HIP adapter.

@GeorgeWeb GeorgeWeb temporarily deployed to aws August 4, 2023 17:28 — with GitHub Actions Inactive
@GeorgeWeb GeorgeWeb temporarily deployed to aws August 4, 2023 18:09 — with GitHub Actions Inactive
@GeorgeWeb GeorgeWeb force-pushed the georgi/hip_memadvise_prefetch branch from 04522a9 to 5fc6616 Compare August 7, 2023 08:52
@GeorgeWeb GeorgeWeb force-pushed the georgi/hip_memadvise_prefetch branch from 5fc6616 to aa4b752 Compare August 7, 2023 08:55
@GeorgeWeb GeorgeWeb temporarily deployed to aws August 7, 2023 09:06 — with GitHub Actions Inactive
@GeorgeWeb GeorgeWeb temporarily deployed to aws August 7, 2023 09:57 — with GitHub Actions Inactive
@GeorgeWeb GeorgeWeb temporarily deployed to aws August 7, 2023 10:46 — with GitHub Actions Inactive
ldrumm
ldrumm reviewed Aug 8, 2023
View reviewed changes
ldrumm
ldrumm reviewed Aug 8, 2023
View reviewed changes
@GeorgeWeb GeorgeWeb temporarily deployed to aws August 8, 2023 14:53 — with GitHub Actions Inactive
@GeorgeWeb GeorgeWeb marked this pull request as ready for review August 8, 2023 16:02
@GeorgeWeb GeorgeWeb requested review from a team as code owners August 8, 2023 16:02
@GeorgeWeb GeorgeWeb temporarily deployed to aws August 8, 2023 16:55 — with GitHub Actions Inactive
jandres742
jandres742 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@jandres742 jandres742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on common code changes.

@GeorgeWeb
Copy link
Contributor Author

Heyo, just a friendly ping @intel/llvm-reviewers-cuda , @intel/llvm-reviewers-runtime if possible to take a look at this one.

steffenlarsen
steffenlarsen reviewed Sep 1, 2023
View reviewed changes
steffenlarsen
steffenlarsen approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GeorgeWeb GeorgeWeb temporarily deployed to WindowsCILock November 2, 2023 12:35 — with GitHub Actions Inactive
@GeorgeWeb
Copy link
Contributor Author

GeorgeWeb commented Nov 2, 2023 •
edited
Loading

Note: The Graph/device_query.cpp test fails on Cuda because this #11133 (comment) needs merged to catch up with the adapter changes. Point is, the failure is not related to this PR. Resolved 🟢.

@GeorgeWeb GeorgeWeb temporarily deployed to WindowsCILock November 2, 2023 17:15 — with GitHub Actions Inactive
@GeorgeWeb GeorgeWeb mentioned this pull request Jan 9, 2024
Closed
@aelovikov-intel aelovikov-intel merged commit a669374 into intel:sycl Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenzie kbenzie kbenzie approved these changes

@npmiller npmiller npmiller approved these changes

@jandres742 jandres742 jandres742 approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov was automatically assigned from intel/llvm-reviewers-cuda

@ldrumm ldrumm Awaiting requested review from ldrumm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@GeorgeWeb @steffenlarsen @kbenzie @ldrumm @npmiller @jandres742 @aelovikov-intel