[UR][CUDA][HIP] Fix Set Arg Local #10710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veselypeta
force-pushed
the
petr/fix-cuda-set-arg-local
branch
from
1a1721d to
291dcb3
Compare
veselypeta
force-pushed
the
petr/fix-cuda-set-arg-local
branch
from
291dcb3 to
2529422
Compare
veselypeta
force-pushed
the
petr/fix-cuda-set-arg-local
branch
from
2529422 to
bd75f00
Compare
jchlanda
approved these changes
Aug 10, 2023
|
CUDA/HIP 👍 |
|
Ping @intel/dpcpp-l0-pi-reviewers can we get a review on this? |
smaslov-intel
approved these changes
Aug 18, 2023
jandres742
approved these changes
Aug 21, 2023
veselypeta
force-pushed
the
petr/fix-cuda-set-arg-local
branch
from
bd75f00 to
a7653f3
Compare
|
@intel/llvm-gatekeepers can this be merged? |
veselypeta
added a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
In the CUDA/HIP adapters `urKernelSetArgValue` was being used to implement both `urKernelSetArgValue` & `urKernelSetArgLocal`. However, if the validation layer is enabled in UR then the path to set local arg is never taken since it includes a check that `pArgValue` is not null. This PR: * Implements `urKernelSetArgLocal` for CUDA/HIP adapters * Changes `pi2ur` to call `urKernelSetArgLocal` when `arg_value` is `nullptr` * Implements `urKernelSetArgLocal` for L0 adapter - this just calls back into `urKernelSetArgValue`.
fabiomestre
pushed a commit
to fabiomestre/llvm
that referenced
this pull request
Sep 26, 2023
In the CUDA/HIP adapters `urKernelSetArgValue` was being used to implement both `urKernelSetArgValue` & `urKernelSetArgLocal`. However, if the validation layer is enabled in UR then the path to set local arg is never taken since it includes a check that `pArgValue` is not null. This PR: * Implements `urKernelSetArgLocal` for CUDA/HIP adapters * Changes `pi2ur` to call `urKernelSetArgLocal` when `arg_value` is `nullptr` * Implements `urKernelSetArgLocal` for L0 adapter - this just calls back into `urKernelSetArgValue`.
veselypeta
added a commit
to veselypeta/llvm
that referenced
this pull request
Sep 28, 2023
In the CUDA/HIP adapters `urKernelSetArgValue` was being used to implement both `urKernelSetArgValue` & `urKernelSetArgLocal`. However, if the validation layer is enabled in UR then the path to set local arg is never taken since it includes a check that `pArgValue` is not null. This PR: * Implements `urKernelSetArgLocal` for CUDA/HIP adapters * Changes `pi2ur` to call `urKernelSetArgLocal` when `arg_value` is `nullptr` * Implements `urKernelSetArgLocal` for L0 adapter - this just calls back into `urKernelSetArgValue`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CUDA/HIP adapters
urKernelSetArgValuewas being used to implement bothurKernelSetArgValue&urKernelSetArgLocal. However, if the validation layer is enabled in UR then the path to set local arg is never taken since it includes a check thatpArgValueis not null.This PR:
urKernelSetArgLocalfor CUDA/HIP adapterspi2urto callurKernelSetArgLocalwhenarg_valueisnullptrurKernelSetArgLocalfor L0 adapter - this just calls back intourKernelSetArgValue.