[SYCL][Driver] -foffload-static-lib improvements when no source is given #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides improvements to behaviors of -foffload-static-lib when no source or object file is also provided on the command line. - Adds new -foffload-whole-static-lib option that is similar to -foffload-static-lib, except during the partial linkage stage. That is where the whole-archive is used to preserve all items in the archive before being unbundled. - Adds the arguments to -foffload-static-lib to be considered as true inputs to the compiler. This triggers proper link steps on the offload side as well as places the library directly on the link. - Moves the static-lib tests into a static-lib specific test Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
reviewed
Feb 3, 2020
Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
reviewed
Feb 6, 2020
AGindinson
reviewed
Feb 6, 2020
Update comments for readability, and improve partial linking step in regards to --whole-archive/--no-whole-archive usage Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
reviewed
Feb 11, 2020
Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
reviewed
Feb 11, 2020
Signed-off-by: Michael D Toguchi <[email protected]>
AGindinson
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides improvements to behaviors of -foffload-static-lib when no source
or object file is also provided on the command line.
-foffload-static-lib, except during the partial linkage stage. That is
where the whole-archive is used to preserve all items in the archive
before being unbundled.
to the compiler. This triggers proper link steps on the offload side as
well as places the library directly on the link.
Signed-off-by: Michael D Toguchi [email protected]