[SYCL] Change command line options for Spec Const lowering in sycl-post-link #10741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksimsab
changed the title
againull
approved these changes
Aug 9, 2023
mdtoguchi
approved these changes
Aug 9, 2023
vmaksimo
reviewed
Aug 10, 2023
Comment on lines
183
to
186
| cl::values(clEnumValN(SC_USE_NATIVE, "native", | ||
| "lower spec constants to native spirv instructions"), | ||
| clEnumValN(SC_USE_EMULATION, "emulation", | ||
| "replace spec constants with emulation technique")), |
There was a problem hiding this comment.
i would personally like if we had also left info about rt/c++ default spec constants in description, because now it's mostly describing the implementation, not the meaning. does it make sense?
There was a problem hiding this comment.
Lowering to default C++ values has been dropped here e50ae05#diff-f9a582625f70ea58ef88b7713c591e8187629cca507b424557a3e4664e23848fL147 when we removed support of sycl_ext_oneapi_spec_constants.
The current value name emulation and desc reflects more precisely what it does.
Changed description a bit.
vmaksimo
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
rtanddefaultvalues of command line option-spec-constwithnativeandemulationrespectively.