[SYCL] Refactor memory objects to improve ABI stability #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
February 2, 2020 15:18
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
romanovvlad
reviewed
Feb 3, 2020
| #include <CL/sycl/detail/sycl_mem_obj_i.hpp> | ||
| #include <CL/sycl/detail/type_traits.hpp> | ||
| #include <CL/sycl/event.hpp> | ||
| #include <CL/sycl/property_list.hpp> | ||
| #include <CL/sycl/stl.hpp> | ||
|
|
||
| #include <type_traits> | ||
| #include <cstring> |
There was a problem hiding this comment.
I believe cstring should be placed before type_traits
There was a problem hiding this comment.
I believe that suggested placement is correct. See LLVM Coding Standards: there are 4 main sections of includes, each of them is sorted alphabetically, but they didn't overlap between each other
There was a problem hiding this comment.
@AlexeySachkov I have moved cstring above type_traits. For some reason GitHub doesn't show this comment as outdated.
added 2 commits
February 4, 2020 10:38
Signed-off-by: Alexander Batashev <[email protected]>
Signed-off-by: Alexander Batashev <[email protected]>
alexbatashev
force-pushed
the
private/abatashe/refactor_buffer
branch
from
6ce3fd0 to
47117d5
Compare
romanovvlad
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a part of effort to decouple SYCL Runtime library
interface from its actual implementation. The goal is to improve
SYCL ABI/API compatibility between different versions of library.
The following changes were applied to SYCLMemObjT, as well as
buffer and image classes:
templates for SYCLMemObjT, buffer_impl, and image_imp.
were refactored to use public APIs only. All usages of private
APIs were moved to cpp files.
and buffer_impl to image and buffer accordingly, since they
did not use any private APIs at all.
Signed-off-by: Alexander Batashev [email protected]