-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL][UR][L0] Don't overwrite context's devices #10794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
They are only set at contextCreate time. Signed-off-by: Jaime Arteaga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@intel/llvm-gatekeepers : please merge when possible. |
If I may, what is the intent behind this change? Should it have any user-facing consequences? I'm asking because it appears that it somehow broke our nightly CI run for Celerity. It seems that kernels on the second GPU no longer execute. What is also notable is that the device names listed are different.
|
Tag @jandres742 about the above comment. |
if those tests were passing before with this fix, it means this change was just allowing them to pass incorrectly. could you please file an internal bug tracker, to take a closer look at those tests? |
This does not appear to be an issue with Celerity. I have built a small reproducer and opened an issue. |
This reverts commit 0e49948.
I have found some tests failing after this patch. Possible fix in #11122 |
They are only set at contextCreate time. Signed-off-by: Jaime Arteaga <[email protected]>
They are only set at contextCreate time.