Skip to content

[SYCL][UR][L0] Don't overwrite context's devices #10794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

jandres742
Copy link
Contributor

They are only set at contextCreate time.

@jandres742 jandres742 requested a review from a team as a code owner August 11, 2023 17:43
They are only set at contextCreate time.

Signed-off-by: Jaime Arteaga <[email protected]>
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jandres742
Copy link
Contributor Author

@intel/llvm-gatekeepers : please merge when possible.

@aelovikov-intel aelovikov-intel merged commit 0e49948 into intel:sycl Aug 14, 2023
@psalz
Copy link
Contributor

psalz commented Aug 15, 2023

If I may, what is the intent behind this change? Should it have any user-facing consequences?

I'm asking because it appears that it somehow broke our nightly CI run for Celerity. It seems that kernels on the second GPU no longer execute.

What is also notable is that the device names listed are different.

Broken run:

[2023-08-15 10:11:04.562] [1] [info] Using platform 'Intel(R) Level-Zero', device 'Intel(R) Arc(TM) A770 Graphics' (automatically selected platform 0, device 1)

Working run:

[2023-08-14 22:13:43.544] [1] [info] Using platform 'Intel(R) Level-Zero', device 'Intel(R) Graphics [0x56a0]' (automatically selected platform 0, device 1)

@steffenlarsen
Copy link
Contributor

Tag @jandres742 about the above comment.

@jandres742
Copy link
Contributor Author

If I may, what is the intent behind this change? Should it have any user-facing consequences?

I'm asking because it appears that it somehow broke our nightly CI run for Celerity. It seems that kernels on the second GPU no longer execute.

What is also notable is that the device names listed are different.

Broken run:

[2023-08-15 10:11:04.562] [1] [info] Using platform 'Intel(R) Level-Zero', device 'Intel(R) Arc(TM) A770 Graphics' (automatically selected platform 0, device 1)

Working run:

[2023-08-14 22:13:43.544] [1] [info] Using platform 'Intel(R) Level-Zero', device 'Intel(R) Graphics [0x56a0]' (automatically selected platform 0, device 1)

if those tests were passing before with this fix, it means this change was just allowing them to pass incorrectly. could you please file an internal bug tracker, to take a closer look at those tests?

@psalz
Copy link
Contributor

psalz commented Aug 28, 2023

This does not appear to be an issue with Celerity. I have built a small reproducer and opened an issue.

jandres742 pushed a commit to jandres742/llvm that referenced this pull request Sep 15, 2023
@jandres742
Copy link
Contributor Author

I have found some tests failing after this patch. Possible fix in #11122

veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 21, 2023
They are only set at contextCreate time.

Signed-off-by: Jaime Arteaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants