Skip to content

[SYCL] Consistently using unsigned loop counter for reduction #10795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

reble
Copy link
Contributor

@reble reble commented Aug 11, 2023

Intended to fix error: comparison of integer expressions of different signedness

note: unrecognized command-line option '-Wno-inconsistent-missing-override' may have been intended to silence earlier diagnostics

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@steffenlarsen
Copy link
Contributor

Failure in CUDA is an infrastructure problem. Merging.

@steffenlarsen steffenlarsen merged commit 8a4182b into intel:sycl Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants