[SYCL] Add 2 queue constructors accepting sycl device argument and context #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlychkov
reviewed
Jan 31, 2020
bader
reviewed
Jan 31, 2020
v-klochkov
force-pushed
the
public_vklochkov_queue_two_ctors
branch
from
10265c4 to
2200fb2
Compare
|
assigned @bader as main reviewer. please approve |
bader
reviewed
Feb 6, 2020
|
If KhronosGroup/SYCL-Docs#71 goes in, we don't need macro guards. Thanks Ruyman for linking the issue. |
keryell
reviewed
Feb 7, 2020
| @@ -116,6 +116,14 @@ KernelProgramCache &context_impl::getKernelProgramCache() const { | |||
| return MKernelProgramCache; | |||
| } | |||
|
|
|||
| bool | |||
| context_impl::hasDevice(std::shared_ptr<detail::device_impl> Device) const { | |||
| for (auto D : MDevices) | |||
There was a problem hiding this comment.
This looks like an STL algorithm. OK, not very compelling while we do not have yet the C++20 syntax here...
v-klochkov
force-pushed
the
public_vklochkov_queue_two_ctors
branch
from
2200fb2 to
6bbb707
Compare
bader
previously requested changes
Feb 11, 2020
v-klochkov
force-pushed
the
public_vklochkov_queue_two_ctors
branch
from
6bbb707 to
f5c85c6
Compare
|
I updated the patch again - removed the guarding macro from queue.hpp and from LIT test because those 2 constructors have been added to SYCL 1.2.1 recently. |
bader
reviewed
Feb 11, 2020
…uments Signed-off-by: Klochkov <[email protected]> Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
public_vklochkov_queue_two_ctors
branch
from
5fb1dfa to
2488236
Compare
bader
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Klochkov [email protected]