Skip to content

[SYCL] Fix missing climits include #10805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Aug 14, 2023

This commit #10648 broke the build with:

/home/hugh/llvm/sycl/source/stream.cpp:19:12: error: ‘CHAR_BIT’ was not declared in this scope
   19 |     (1 << (CHAR_BIT * detail::FLUSH_BUF_OFFSET_SIZE)) - 1;
      |            ^~~~~~~~
/home/hugh/llvm/sycl/source/stream.cpp:12:1: note: ‘CHAR_BIT’ is defined in header ‘<climits>’; did you forget to ‘#include <climits>’?
   11 | #include <sycl/properties/all_properties.hpp>
  +++ |+#include <climits>
   12 | #include <sycl/stream.hpp>

This fixes that

@hdelan hdelan requested a review from a team as a code owner August 14, 2023 10:51
@hdelan hdelan requested a review from againull August 14, 2023 10:51
@hdelan
Copy link
Contributor Author

hdelan commented Aug 16, 2023

Duplicate of #10726

@hdelan hdelan marked this as a duplicate of #10726 Aug 16, 2023
@hdelan hdelan closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants