[SYCL][UR][L0] Replace memory type look-up with UMF tracking #10807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
reviewed
Aug 14, 2023
igchor
reviewed
Aug 17, 2023
kswiecicki
force-pushed
the
llvm-disjoint-pool-free-usm-tracking
branch
3 times, most recently
from
4bc2fef to
64de0f8
Compare
igchor
reviewed
Aug 23, 2023
| umf_result_t get_min_page_size(void *, size_t *); | ||
| umf_result_t get_recommended_page_size(size_t, size_t *) { | ||
| virtual void get_last_native_error(const char **ErrMsg, int32_t *ErrCode) { | ||
| std::ignore = ErrMsg; |
There was a problem hiding this comment.
This is unrelated to this PR, but I think it would be good to actually call zeDriverGetLastErrorDescription here.
| // capabilities. | ||
| class USMProxyPool { | ||
| class L0ProxyPool { |
There was a problem hiding this comment.
Is it somehow specific to L0? I guess we could use it for other adapters as well?
There was a problem hiding this comment.
My bad. I've been using it only in the context of L0.
kswiecicki
force-pushed
the
llvm-disjoint-pool-free-usm-tracking
branch
6 times, most recently
from
401b08a to
52d7266
Compare
This also makes SharedReadOnly allocations tracking obsolete.
To make use of the USM pool tracking capabilities direct memory allocations are now made through USMProxyPool.
UsmHostFlags was previously passed to the USMSharedAllocImpl as unnamed parameter. Currently it's not passed directly anywhere and causes variable set but not used error.
L0 adapter no longer needs to call zeMemGetAllocProperties to match an allocation with the corresponding pool. UMF now takes care of that.
kswiecicki
force-pushed
the
llvm-disjoint-pool-free-usm-tracking
branch
from
52d7266 to
7fafe41
Compare
bso-intel
approved these changes
Sep 12, 2023
jandres742
reviewed
Sep 12, 2023
jandres742
approved these changes
Sep 14, 2023
|
Failure in post-commit: @kswiecicki please, fix ASAP and add a link to the PR with the fix here |
|
@dm-vodopyanov |
againull
pushed a commit
that referenced
this pull request
Sep 14, 2023
Post-commit error fix for: #10807
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
…0807) This also makes SharedReadOnly allocations tracking obsolete.
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
Post-commit error fix for: intel#10807
omarahmed1111
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Oct 23, 2023
Post-commit error fix for: intel/llvm#10807
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes SharedReadOnly allocations tracking obsolete.