[SYCL][PI][UR] Correctly convert program build info from ur to pi #10828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandres742
approved these changes
Aug 15, 2023
jandres742
previously requested changes
Aug 21, 2023
jandres742
dismissed
their stale review
Approach is good based on discussion on oneapi-src/unified-runtime#804
jandres742
reviewed
Aug 23, 2023
|
@veselypeta please check the lint errors. |
jandres742
approved these changes
Aug 23, 2023
|
@kbenzie : please check. |
|
@intel/llvm-gatekeepers can this be merged? |
dm-vodopyanov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was flagged oneapi-src/unified-runtime#804. The pi2ur layer should convert unified runtime info query values to valid PI ones.