Skip to content

[SYCL][Graph] Fix switch statement for Clang build #10923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2023
Merged

[SYCL][Graph] Fix switch statement for Clang build #10923

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea2d38d
[SYCL][Graph] Fix switch statement for Clang build
EwanC Aug 22, 2023
9b3ea94
Remove constexpr due to presence of assert
EwanC Aug 22, 2023
c788968
Use inline on helper function
EwanC Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sycl/include/sycl/ext/oneapi/experimental/graph.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ enum class UnsupportedGraphFeatures {
sycl_ext_oneapi_bindless_images = 7
};

constexpr const char *
inline const char *
UnsupportedFeatureToString(UnsupportedGraphFeatures Feature) {
using UGF = UnsupportedGraphFeatures;
switch (Feature) {
Expand All @@ -64,9 +64,10 @@ UnsupportedFeatureToString(UnsupportedGraphFeatures Feature) {
return "sycl_ext_oneapi_device_global";
case UGF::sycl_ext_oneapi_bindless_images:
return "sycl_ext_oneapi_bindless_images";
default:
return {};
}

assert(false && "Unhandled graphs feature");
return {};
}

class node_impl;
Expand Down