[SYCL] Skip device diagnostics for unevaluated functions. #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichkeane
reviewed
Feb 3, 2020
ilyastepykin
force-pushed
the
diag-uneval-funcs
branch
from
0e7c4ab to
60c68e5
Compare
bader
reviewed
Feb 4, 2020
Fznamznon
reviewed
Feb 4, 2020
Do not produce an error if some restricted feature (e.g. exceptions) is used by a function only referenced in unevaluated context(e.g. in decltype expression) In order to do that, skip such functions when extracting device part of the code. Signed-off-by: Ilya Stepykin <[email protected]>
ilyastepykin
force-pushed
the
diag-uneval-funcs
branch
from
60c68e5 to
7e0881e
Compare
erichkeane
approved these changes
Feb 4, 2020
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
Fixed kernel bundle related tests. The following tests were just missing SYCL triple in the compile commands: KernelAndProgram/kernel-bundle-merge-options.cpp KernelAndProgram/kernel-bundle-merge-options-env.cpp KernelAndProgram/multiple-kernel-linking.cpp The following tests are checking that compilation errors are reported during runtime, but for CUDA and HIP these are actually reported at compile time. So these were marked as unsupported and a comment was added mentioning that: KernelAndProgram/cache-build-result.cpp KernelAndProgram/build-log.cpp KernelAndProgram/undefined-symbol.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not produce an error if some restricted feature
(e.g. exceptions) is used by a function only referenced
in unevaluated context(e.g. in decltype expression)
In order to do that, skip such functions when extracting
device part of the code.
Signed-off-by: Ilya Stepykin [email protected]