[SYCL] annotated_ptr API fixes part 3 #10936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge until part 2 (#10928) is merged. |
Pennycook
approved these changes
Aug 24, 2023
broxigarchen
approved these changes
Aug 29, 2023
GarveyJoe
reviewed
Aug 30, 2023
sycl/include/sycl/ext/oneapi/experimental/annotated_ptr/annotated_ptr.hpp
Outdated
Show resolved
Hide resolved
tiwaria1
suggested changes
Sep 1, 2023
sycl/include/sycl/ext/oneapi/experimental/annotated_ptr/annotated_ptr.hpp
Outdated
Show resolved
Hide resolved
tiwaria1
approved these changes
Sep 12, 2023
aelovikov-intel
approved these changes
Sep 29, 2023
|
@rolandschulz do you want me to merge this? Or are we waiting for somebody else to take a look? |
|
I think this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate implicit constructor by marking constructor explicit and adding new deprecated implicit constructor.
This is separate because it won't be included in 2024.0.