Skip to content

[Matrix][AMX] correct REQUIRES field since they are gpu testcase #10964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

[Matrix][AMX] correct REQUIRES field since they are gpu testcase #10964

merged 1 commit into from
Aug 28, 2023

Conversation

yubingex007-a11y
Copy link
Contributor

No description provided.

dkhaldi
dkhaldi approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yubingex007-a11y yubingex007-a11y requested a review from a team August 26, 2023 13:50
@aelovikov-intel
Copy link
Contributor 

********************
Timed Out Tests (1):
  SYCL :: Basic/fill_accessor.cpp

on HIP is unexpected. @yubingex007-a11y , next time please, at least, do what I've done here to make such failures searchable before asking gatekeepers.

@aelovikov-intel aelovikov-intel merged commit aa43146 into intel:sycl Aug 28, 2023
@dm-vodopyanov dm-vodopyanov mentioned this pull request Aug 28, 2023
Closed
@dm-vodopyanov
Copy link
Contributor

Unrelated (flaky?) failure in post-commit on Windows:
https://github.com/intel/llvm/actions/runs/6001360490/job/16275376437
Issue: #10985

FAIL: SYCL-Unit :: Extensions/./ExtensionsTests.exe/9/11 (371 of 488)
******************** TEST 'SYCL-Unit :: Extensions/./ExtensionsTests.exe/9/11' FAILED ********************
Script(shard):
--
GTEST_OUTPUT=json:D:\github\_work\llvm\llvm\build\tools\sycl\unittests\Extensions\.\ExtensionsTests.exe-SYCL-Unit-1332-9-11.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=11 GTEST_SHARD_INDEX=9 D:\github\_work\llvm\llvm\build\tools\sycl\unittests\Extensions\.\ExtensionsTests.exe
--

Script:
--
D:\github\_work\llvm\llvm\build\tools\sycl\unittests\Extensions\.\ExtensionsTests.exe --gtest_filter=MultiThreadGraphTest.Finalize
--
unknown file: error: SEH exception with code 0x32[212](https://github.com/intel/llvm/actions/runs/6001360490/job/16275376437#step:10:213)25477 thrown in the test body.

unknown file
SEH exception with code 0x3221225477 thrown in the test body.


********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  SYCL-Unit :: Extensions/./ExtensionsTests.exe/MultiThreadGraphTest/Finalize

@yubingex007-a11y
Copy link
Contributor Author 

********************
Timed Out Tests (1):
  SYCL :: Basic/fill_accessor.cpp

on HIP is unexpected. @yubingex007-a11y , next time please, at least, do what I've done here to make such failures searchable before asking gatekeepers.

sorry i had too much worlkoad to remember the procedure. next time i will keep in mind

@mfrancepillois mfrancepillois mentioned this pull request Aug 29, 2023
Merged
bader pushed a commit that referenced this pull request Aug 30, 2023
@mfrancepillois
[SYCL][Graph] Fix unit test multithread finalize bug (#11006)
4ddb952 
Adds a mutex to prevent races when inserting data into the STL map.

This PR addresses issue #10985 
(i.e. it fixes the post-commit CI fail of PR
#10964
(https://github.com/intel/llvm/actions/runs/6001360490/job/16275376437)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriPlyakhin YuriPlyakhin YuriPlyakhin approved these changes

@dkhaldi dkhaldi dkhaldi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yubingex007-a11y @aelovikov-intel @dm-vodopyanov @YuriPlyakhin @dkhaldi