Skip to content

[SYCL-WEB] Sync VTable related customization with sycl branch #10993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[SYCL-WEB] Sync VTable related customization with sycl branch #10993

merged 1 commit into from
Aug 30, 2023

Conversation

jsji
Copy link
Contributor

@jsji jsji commented Aug 28, 2023

Fixed CodeGenSYCL/virtual-types.cpp

@jsji jsji requested a review from a team as a code owner August 28, 2023 23:07
@bader bader requested a review from KornevNikita August 28, 2023 23:09
@jsji
Copy link
Contributor Author

jsji commented Aug 28, 2023

This is exposed after -DINTEL_SYCL_OPAQUEPOINTER_READY=1, I am not sure this update is right, can someone familiar with it have a look and fix it? Maybe we some code previously guarded with #ifdef INTEL_SYCL_OPAQUEPOINTER_READY was wrong. Thanks.

@jsji jsji changed the title Update virtual-types.cpp [SYCL-WEB] Update virtual-types.cpp Aug 29, 2023
@jsji jsji changed the title [SYCL-WEB] Update virtual-types.cpp [SYCL-WEB] Sync VTable related customization with sycl branch Aug 30, 2023
@jsji jsji requested a review from elizabethandrews August 30, 2023 18:29
to keep some customization.
@jsji
Copy link
Contributor Author

jsji commented Aug 30, 2023

@AlexeySachkov @elizabethandrews @jyu2-git Synced with sycl branch, the change now can get the test pass without changing addrspace. I think we can use this version first, while @jyu2-git working on the changes related to https://reviews.llvm.org/D153092 . What do you think? Thanks!

@elizabethandrews
Copy link
Contributor

@AlexeySachkov @elizabethandrews @jyu2-git Synced with sycl branch, the change now can get the test pass without changing addrspace. I think we can use this version first, while @jyu2-git working on the changes related to https://reviews.llvm.org/D153092 . What do you think? Thanks!

I am ok with this. SYCL branch was different from community clang here previously as well. So I don't see any (additional) harm.

@jsji jsji merged commit 503b88f into intel:sycl-web Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants