[SYCL] Optimize urEnqueueEventsWaitWithBarrier for in-order queues #10995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't insert zeCommandListAppendWaitOnEvents/zeCommandListAppendSignalEvent for queue::ext_oneapi_submit_barrier() if we have in-order queue and all events in the waitlist are from the same queue.
jandres742
reviewed
Aug 29, 2023
| if (!EventWaitList.Length) | ||
| return true; | ||
|
|
||
| auto Queue = EventWaitList.UrEventList[0]->UrQueue; |
There was a problem hiding this comment.
is this the same queue from the original scope, in line 169 below? if so, maybe we can just pass it to the lambda?
is that the same queue from the original scope?
if (Queue->isInOrderQueue() &&
EmptyOrAllEventsFromSameQueue(EventWaitList) &&
Queue->LastCommandEvent && !Queue->LastCommandEvent->IsDiscarded) {
| // For in-order queue and wait-list which is empty or has events from | ||
| // the same queue just use the last command event as the barrier event. | ||
| if (Queue->isInOrderQueue() && | ||
| EmptyOrAllEventsFromSameQueue(EventWaitList) && |
There was a problem hiding this comment.
I think you need to pass queue, as this can only be optimized if events on waitlist have the same que as LastCommandEvent, if events are coming from other queue , even though it is the same, the Last Event wouldn't represent proper status as we need to wait on those.
There was a problem hiding this comment.
Yes, I agree, fixed.
jandres742
approved these changes
Aug 31, 2023
|
@sergey-semenov Friendly ping. |
sergey-semenov
approved these changes
Aug 31, 2023
veselypeta
pushed a commit
to veselypeta/llvm
that referenced
this pull request
Sep 21, 2023
…ntel#10995) Don't insert zeCommandListAppendWaitOnEvents/zeCommandListAppendSignalEvent for queue::ext_oneapi_submit_barrier() if we have in-order queue and all events in the waitlist are from the same queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't insert zeCommandListAppendWaitOnEvents/zeCommandListAppendSignalEvent for queue::ext_oneapi_submit_barrier() if we have in-order queue and all events in the waitlist are from the same queue.