[SYCL] Use SYCL containers in accessor_impl.hpp #1102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
previously approved these changes
Feb 6, 2020
bader
reviewed
Feb 7, 2020
| @@ -13,6 +13,7 @@ | |||
| #include <CL/sycl/detail/sycl_mem_obj_i.hpp> | |||
| #include <CL/sycl/id.hpp> | |||
| #include <CL/sycl/range.hpp> | |||
| #include <CL/sycl/stl.hpp> | |||
|
|
|||
| #include <memory> | |||
There was a problem hiding this comment.
Do we still need this include?
There was a problem hiding this comment.
@bader we still use std::make_shared. There's no SYCL alternative now, AFAIK.
There was a problem hiding this comment.
I'm a bit lost. What is the purposed of this patch? Could you elaborate more on that in the description?
Do you really need to use std::make_shared? I thought this utility simplifies the pointer constructions, but you call it directly. Right?
Signed-off-by: Alexander Batashev <[email protected]>
alexbatashev
force-pushed
the
private/abatashe/refactor_accessor
branch
from
ddcd623 to
952a313
Compare
bader
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Batashev [email protected]