-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][clang-offload-bundler] Add support for BC files in archives. #11034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you please elaborate here on why this change is required? For a generic target audience. Thanks |
The ability to maintain the symbols and properties as generated when creating early FPGA images is required when moving from early archives to image archives or executables. This information is retained in the wrapped device image. This image needs to be retained in the FPGA early archive as a bundled wrapped file (wrapped files are .bc files) where the compiler can obtain this wrapped file and process it for final image generation and providing these symbols and properties in the final image of the executable. |
clang/test/Driver/clang-offload-bundler-bc-archive-support2.cpp
Outdated
Show resolved
Hide resolved
clang/test/Driver/clang-offload-bundler-bc-archive-support2.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Lu, John <[email protected]>
…BC files. Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
… is linux-specific Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
…nux suffix. Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
auto CheckOrErr = CheckIfObjectFileContainsExcludedTargets(C); | ||
if (!CheckOrErr) | ||
return CheckOrErr.takeError(); | ||
auto CheckOrErr = CheckIfObjectFileContainsExcludedTargets(C); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @maksimsab
We are trying to add support here for cases where the archive file will contain .bc file. Previously, we handle only those archive files which have .o files.
Can you please comment if we will need this check for archives containing .bc files?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know at the moment whether we will need it in the future.
This particular piece of code was related to handling of "FPGA" part. Frankly speaking, we don't have a concrete design for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. Minor tweaks requested.
Thanks
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
Signed-off-by: Lu, John <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for driver
Add support for -list, -check-section, and -unbundle for bundled BC files in archives.