[SYCL] Check if Plugin before all calls to a plugin API #11128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Sep 8, 2023
nrspruit
commented
- Using Teardown tracking of "pluginReleased", check if the plugin is released before each call to a plugin's functions.
nrspruit
force-pushed
the
sycl_plugin_released
branch
from
3786869 to
3c219a6
Compare
- Using Teardown tracking of "pluginReleased", check if the plugin is released before each call to a plugin's functions. Signed-off-by: Spruit, Neil R <[email protected]>
nrspruit
force-pushed
the
sycl_plugin_released
branch
from
3c219a6 to
cd28adb
Compare
steffenlarsen
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
LGTM! 🚀
@nrspruit - For future reference, please avoid force-pushing as much as possible. Not doing so helps us understand the history of the PR better. The patch will be squished into a single PR when we merge. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.