[SYCL][Driver] Fix -save-temps for SYCL compilations #1114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asavonic
previously requested changes
Feb 11, 2020
AGindinson
commented
Feb 11, 2020
mdtoguchi
reviewed
Feb 11, 2020
The following issues have been blocking the correct functioning of -save-temps in the presence of -fsycl: 1. LLVM BC -> host assembly transformation naturally crashes upon encountering a SYCL device triple. Without -save-temps, this was hidden due to compile/backend/assemble actions collapsing, however the need to save all intermediate results uncovers the issue. Solution: remove backend/assemble actions from the SYCL device flow altogether, as these do not carry practical value anyway. 2. The integration header name being emptied by -save-temps enabling. This is due to a bug in the llvm::sys::fs::real_path() function - the Unix implementation doesn't guarantee a valid path for non-existent files. Solution: work around the issue by placing the Windows-specific caller code under an OS preprocessor check. Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
force-pushed
the
private/agindins/fsycl-save-temps
branch
from
2e018e5 to
daa083b
Compare
|
Resolved conflicts, squashed the commits, updated the main commit message/description to reflect @asavonic's review. |
Signed-off-by: Artem Gindinson <[email protected]>
AGindinson
force-pushed
the
private/agindins/fsycl-save-temps
branch
from
51e119b to
fcefcb2
Compare
mdtoguchi
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following issues have been blocking the correct functioning
of -save-temps in the presence of -fsycl:
LLVM BC -> host assembly transformation naturally crashes upon
encountering a SYCL device triple. Without -save-temps, this was
hidden due to compile/backend/assemble actions collapsing, however
the need to save all intermediate results uncovers the issue.
Solution: remove backend/assemble actions from the SYCL device flow
altogether, as these do not carry practical value anyway.
The integration header name being emptied by -save-temps enabling.
This is due to a bug in the llvm::sys::fs::real_path() function -
the Unix implementation doesn't guarantee a valid path for non-existent
files.
Solution: work around the issue by placing the Windows-specific caller
code under an OS preprocessor check.
Signed-off-by: Artem Gindinson [email protected]