[SYCL][NATIVECPU] Add SPIR-V work-group/item builtins on Windows #11158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
uwedolinsky
commented
Sep 12, 2023
uwedolinsky
commented
- Enabling translation of calls to SpirV workgroup and workitem functions into calls to NativeCPU builtins on Windows.
- Enabling NativeCPU test previously unsupported on Windows.
- BuiltinMap now uses StringRef making the initialization static.
uwedolinsky
changed the title
|
Hello @intel/llvm-gatekeepers , we think this PR could be merged. Thank you! |
dm-vodopyanov
requested changes
Sep 13, 2023
dm-vodopyanov
changed the title
dm-vodopyanov
approved these changes
Sep 13, 2023
Thank you for spotting this. I've changed it back to 644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.