Skip to content

[SYCL][NATIVECPU] Fix unused condition #11161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2023
Merged

[SYCL][NATIVECPU] Fix unused condition #11161

merged 2 commits into from
Sep 14, 2023

Conversation

vmaksimo
Copy link
Contributor

@vmaksimo vmaksimo commented Sep 13, 2023 •
edited by bader
Loading

Update ModuleChange variable in the loop, so the condition is not always falling to "false" branch

@vmaksimo
Remove unused condition
3421403 
As `ModuleChange` is always false, remove unneeded dead code.
@vmaksimo vmaksimo requested a review from a team as a code owner September 13, 2023 10:09
@PietroGhg
Copy link
Contributor

Thanks for the PR, the original intent here was to update ModuleChanged when the functions are renamed, but I made a mistake an missed it, sorry about that. This made me realize that I'm actually not sure how renaming a function may impact analysis results, so maybe it's safer to change it to do ModuleChanged |= true; after a function gets renamed?

@vmaksimo
Copy link
Contributor Author

Thanks for the PR, the original intent here was to update ModuleChanged when the functions are renamed, but I made a mistake an missed it, sorry about that. This made me realize that I'm actually not sure how renaming a function may impact analysis results, so maybe it's safer to change it to do ModuleChanged |= true; after a function gets renamed?

@PietroGhg I guess it'd be safely indeed. Thanks for a suggestion :)

@vmaksimo vmaksimo changed the title Remove unused condition Fix unused condition Sep 13, 2023
PietroGhg
PietroGhg approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :)

@PietroGhg PietroGhg changed the title Fix unused condition [SYCL][NATIVECPU] Fix unused condition Sep 13, 2023
@bader bader merged commit fb1d712 into intel:sycl Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroGhg PietroGhg PietroGhg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmaksimo @PietroGhg @bader