Skip to content

[SYCL] Implement sub_group_mask version 2 #11195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 2, 2023
Merged

[SYCL] Implement sub_group_mask version 2 #11195

merged 14 commits into from
Oct 2, 2023

Conversation

KornevNikita
Copy link
Contributor

steffenlarsen and others added 2 commits September 14, 2023 02:55
@steffenlarsen @KornevNikita
[SYCL] Implement sub_group_mask version 2
6bc3d1e 
This commit implements version 2 of the sub_group_mask extension.

Signed-off-by: Larsen, Steffen <[email protected]>
@KornevNikita
Test
c3af751
@KornevNikita KornevNikita requested a review from a team as a code owner September 15, 2023 15:59
steffenlarsen
steffenlarsen reviewed Sep 15, 2023
View reviewed changes
steffenlarsen
steffenlarsen reviewed Sep 15, 2023
View reviewed changes
@KornevNikita KornevNikita requested a review from a team as a code owner September 18, 2023 16:46
Alcpz
Alcpz approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@Alcpz Alcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in sycl/include/syclcompat/memory.hpp look good.

steffenlarsen
steffenlarsen approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⚡

jzc
jzc reviewed Sep 25, 2023
View reviewed changes
@KornevNikita KornevNikita temporarily deployed to WindowsCILock September 27, 2023 09:12 — with GitHub Actions Inactive
@KornevNikita
Revert "Apply suggestion"
739885f 
This reverts commit a22890d.
@KornevNikita KornevNikita temporarily deployed to WindowsCILock September 27, 2023 13:02 — with GitHub Actions Inactive
@KornevNikita
Copy link
Contributor Author

I thought this change 739885f caused the failure, so reverted it to check. But looks like the problem is in the original version also. Will check.

@KornevNikita KornevNikita temporarily deployed to WindowsCILock September 29, 2023 15:25 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to WindowsCILock September 29, 2023 16:30 — with GitHub Actions Inactive
@KornevNikita KornevNikita requested a review from jzc September 29, 2023 19:15
@steffenlarsen steffenlarsen merged commit 3bd09b9 into intel:sycl Oct 2, 2023
@KornevNikita KornevNikita mentioned this pull request Oct 2, 2023
Closed
KornevNikita added a commit to KornevNikita/llvm that referenced this pull request Dec 22, 2023
@KornevNikita
Revert "[SYCL] Implement sub_group_mask version 2 (intel#11195)"
263cb80 
This reverts commit 3bd09b9.
aelovikov-intel pushed a commit that referenced this pull request Dec 22, 2023
@KornevNikita
Revert "[SYCL] Implement sub_group_mask version 2 (#11195)" (#12239)
fb8c82d 
This reverts commit 3bd09b9.

Reverting as it affects performance. Will re-introduce later.
KornevNikita added a commit to KornevNikita/llvm that referenced this pull request Jan 16, 2024
@KornevNikita
[SYCL] Reintroduce sub_group_mask version 2
d6d9fa9 
Was reverted by fb8c82d due to
perfomance regressions on some devices.

It turned out that the problem is not with this patch. So applying it
again without any changes.

Previously reviewed here: intel#11195
@KornevNikita KornevNikita mentioned this pull request Jan 16, 2024
Merged
steffenlarsen pushed a commit that referenced this pull request Jan 17, 2024
@KornevNikita
[SYCL] Reintroduce sub_group_mask version 2 (#12404)
f924aa0 
Was reverted by fb8c82d due to
performance regressions on some devices.

It turned out that the problem is not with this patch. So applying it
again without any changes.

Previously reviewed here: #11195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pennycook Pennycook Pennycook left review comments

@Alcpz Alcpz Alcpz approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@jzc jzc Awaiting requested review from jzc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KornevNikita @Pennycook @Alcpz @jzc @steffenlarsen