[SYCL][Matrix Headers] Add out of bounds load/store #11210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhaldi
requested review from
YuriPlyakhin,
yubingex007-a11y and
a team
as code owners
|
Is this PR still alive and under consideration? |
Yes, it is. This PR depends on design decisions we need to make in the spec PR: #11172. So I won't change this one until we have a somewhat stable spec. |
YuriPlyakhin
reviewed
Dec 6, 2023
YuriPlyakhin
reviewed
Dec 6, 2023
YuriPlyakhin
reviewed
Dec 6, 2023
YuriPlyakhin
reviewed
Dec 6, 2023
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
…ew use case where coords are negative values and cannot be taken into account with the offset pointer solution
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers, all green, can you please merge |
That's not true:
|
|
@intel/llvm-reviewers-runtime, please help review |
|
@intel/llvm-reviewers-runtime, please help review |
Please see my review above. |
cperkinsintel
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec is in #11172