[SYCL][HIP] Keep track of only shared USM allocations and prefetch only for those #11218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdelan
force-pushed
the
make-prefetch-only-for-shared-usm
branch
from
0c1badb to
0b17c0b
Compare
jchlanda
reviewed
Sep 21, 2023
hdelan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hdelan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hdelan
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10430 caused a perf regression. This does the same prefetching but only for shared USM allocations, not for all USM allocations. This should revert some of the perf regression for non shared USM. Patch to follow to minimize perf hit unless using problematic instructions.