Skip to content

[SYCL][LIBCLC] Accept text-based IR in prepare builtins utils #11230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SYCL][LIBCLC] Accept text-based IR in prepare builtins utils #11230

wants to merge 1 commit into from

Conversation

jchlanda
Copy link
Contributor

Also get rid of checks for old LLVM versions.

@jchlanda
[SYCL][LIBCLC] Accept text-based IR in prepare builtins utils
a157e7d 
Also get rid of checks for old LLVM versions.
@jchlanda jchlanda requested a review from a team as a code owner September 20, 2023 06:27
@steffenlarsen
Copy link
Contributor

These don't seem like SYCL-specific changes. Should they be brought to upstream LLVM instead?

@jchlanda
Copy link
Contributor Author

These don't seem like SYCL-specific changes. Should they be brought to upstream LLVM instead?

Somehow, it didn't occur to me that libclc is also an upstream thing. Will close this one and go upstream, like you suggest. Thanks!

@jchlanda jchlanda closed this Sep 20, 2023
@jchlanda
Copy link
Contributor Author

FYI, upstream llvm PR: llvm/llvm-project#66993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen Awaiting requested review from steffenlarsen steffenlarsen is a code owner automatically assigned from intel/llvm-reviewers-cuda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchlanda @steffenlarsen