[SYCL-MLIR][cgeist] Do not use SingleBlock::push_back on gpu.module
#11270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only review 94182960f2ebff9da93511f185c5da023b8367a8 |
sommerlukas
approved these changes
Sep 22, 2023
whitneywhtsang
approved these changes
Sep 22, 2023
…6655) Instead of checking whether the last operation might be a terminator, always insert operations to the end of the block. Signed-off-by: Victor Perez <[email protected]>
…6870) This `Block` member function may be misleading to users as the last operation in the block might have not been registered, so there would be no way to ensure that is a terminator. Signed-off-by: Victor Perez <[email protected]>
This leads to pushing operations after the terminator. Signed-off-by: Victor Perez <[email protected]>
victor-eds
force-pushed
the
rebase-singleblock
branch
from
9418296 to
3640d63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH AND MERGE THIS PR
Adapt to upstream
SingleBlockandBlockchanges after conversation