[SYCL] Add buffer dimensions restriction #1128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a static_assert to the buffer dimensions. Signed-off-by: amochalo <[email protected]>
asavonic
suggested changes
Feb 13, 2020
Signed-off-by: amochalo <[email protected]>
Fznamznon
reviewed
Feb 13, 2020
Signed-off-by: amochalo <[email protected]>
AGindinson
reviewed
Feb 14, 2020
Comment on lines
+373
to
+376
|
|
||
| static_assert (dimensions > 0 && dimensions <= 3, | ||
| "Range of the buffer can only be 1/2/3 dimensional."); | ||
|
|
There was a problem hiding this comment.
I believe clang-format should applied for the commit.
bader
changed the title
bader
reviewed
Feb 18, 2020
| @@ -370,6 +370,10 @@ class buffer { | |||
| return newRange[0] == 1 && newRange[2] == parentRange[2]; | |||
| return newRange[1] == parentRange[1] && newRange[2] == parentRange[2]; | |||
| } | |||
|
|
|||
| static_assert (dimensions > 0 && dimensions <= 3, | |||
| "Range of the buffer can only be 1/2/3 dimensional."); | |||
There was a problem hiding this comment.
Suggested change
| "Range of the buffer can only be 1/2/3 dimensional."); | |
| "A SYCL buffer can only be 1/2/3 dimensional."); |
What does "Range of the buffer" mean?
aarongreig
added a commit
to aarongreig/intel-llvm
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a static_assert to the buffer dimensions.
Signed-off-by: amochalo [email protected]