[SYCL][Graph] Add support for enabling Command-Buffer profiling #11324

mfrancepillois · 2023-09-27T14:01:38Z

Support for graph execution profiling

Modifies the urEventGetProfilingInfo function to get the CommandBuffer start time from sync point timestamps.
Approximates the submit time if the difference between the estimated device clock (from which the submit time is taken) and the actual device clock is greater than the elapsed time between the command-buffer submission and its start (involving an event sequence issue, i.e. submit time can be after start time)
Adds a profiling e2e test.
Updates the design doc

…ling (#318) * [SYCL][Graph] Add e2e test checking profiling info Adds an e2e test that checks the profiling info from an event returned by a graph submission. Closes Issue: #96 * [SYCL][Graph] Update the implementation to support Profiling on graph execution Sycl event impl object contains a flag indicating that this event results from a graph submission. This flag was not set for every type of graph sumbission. This commit fixes this bug. Adds a extra event in the first command list associated to the CommandBuffer execution to obtain the start time of the graph execution. Modifies the urEventGetProfilingInfo function to get the CommandBuffer start time from this new event. Improves to profiling e2e test. Removes the test checking for exception throwing (unsupported feature). * [SYCL][Graph] Add resync of submit time to start time if time shift * [SYCL][Graph] Adds condition on queue prop before adding the new profiling event to CL

CUDA backend support for commandbuffer has not yet been merged, so we are disabling the test using CUDA backend in this PR.

EwanC · 2023-10-02T12:25:45Z

Hi @tovinkere, could you review this PR?
Although the work needs rebased and has a CI fail, it would be good to know if the overall approach is a good design, and I believe you have some insight on profiling.

tovinkere · 2023-10-03T15:10:30Z

Hi @tovinkere, could you review this PR? Although the work needs rebased and has a CI fail, it would be good to know if the overall approach is a good design, and I believe you have some insight on profiling.

@EwanC @reble Pablo and I had a quick sync and we will create a table of all the events that must be enabled and should be the input to an implementation and validation plan.

…lvm into command-buffer-profiling-support

EwanC

Some minor comments on the test

sycl/test-e2e/Graph/event_profiling_info.cpp

kbenzie

oneapi-src/unified-runtime#1035 has merged, please pull in the latest changes from the sycl branch, update the UR tag as suggested, then make the ready for review.

sycl/plugins/unified_runtime/CMakeLists.txt

…ing-support

aarongreig · 2024-01-12T11:58:17Z

@intel/llvm-reviewers-runtime please review when you can

steffenlarsen

Small nit, otherwise LGTM!

sycl/source/detail/event_impl.cpp

Co-authored-by: Steffen Larsen <[email protected]>

sycl/doc/design/CommandGraph.md

reble

LGTM! Small nit.

Co-authored-by: Pablo Reble <[email protected]>

EwanC · 2024-01-18T16:28:02Z

@intel/llvm-gatekeepers I think this is ready to merge

Merged PR intel#11324 introduced the ability to profile an executable graph submission. However, the specification limitation section was not updated to reflect this which is addressed in this PR.

Merged PR #11324 introduced the ability to profile an executable graph submission. However, the specification limitation section was not updated to reflect this, which is addressed in this PR.

mfrancepillois requested review from a team as code owners September 27, 2023 14:01

mfrancepillois requested a review from cperkinsintel September 27, 2023 14:01

clang-format

b5d1b50

mfrancepillois temporarily deployed to WindowsCILock September 27, 2023 14:05 — with GitHub Actions Inactive

Disable cuda for this test

2e326f6

CUDA backend support for commandbuffer has not yet been merged, so we are disabling the test using CUDA backend in this PR.

mfrancepillois temporarily deployed to WindowsCILock September 27, 2023 14:24 — with GitHub Actions Inactive

mfrancepillois had a problem deploying to WindowsCILock September 27, 2023 14:49 — with GitHub Actions Failure

reble requested a review from tovinkere September 27, 2023 15:07

mfrancepillois marked this pull request as draft November 3, 2023 09:37

mfrancepillois added 2 commits November 3, 2023 11:41

Merge branch 'sycl' into command-buffer-profiling-support

7e9f0d0

Updates UR CMakefile

fd90613

mfrancepillois mentioned this pull request Nov 3, 2023

[EXP][CMDBUF] Add support for recovering CommandBuffer profiling information oneapi-src/unified-runtime#1035

Merged

mfrancepillois added 2 commits November 9, 2023 16:55

Updates UR CMakefile

c4f8b79

Merge branch 'sycl' into command-buffer-profiling-support

6109e60

mfrancepillois temporarily deployed to WindowsCILock November 9, 2023 18:36 — with GitHub Actions Inactive

mfrancepillois had a problem deploying to WindowsCILock November 9, 2023 20:25 — with GitHub Actions Failure

mfrancepillois added 2 commits November 10, 2023 17:34

Updates UR CMakefile

b22c8fd

Merge branch 'command-buffer-profiling-support' of github.com:reble/l…

35dc10b

…lvm into command-buffer-profiling-support

mfrancepillois temporarily deployed to WindowsCILock November 10, 2023 17:44 — with GitHub Actions Inactive

mfrancepillois had a problem deploying to WindowsCILock November 10, 2023 18:26 — with GitHub Actions Failure

Updates CMakeFile

55c8d87

mfrancepillois had a problem deploying to WindowsCILock November 13, 2023 12:08 — with GitHub Actions Failure

mfrancepillois had a problem deploying to WindowsCILock November 13, 2023 12:39 — with GitHub Actions Failure

EwanC reviewed Nov 13, 2023

View reviewed changes

sycl/test-e2e/Graph/event_profiling_info.cpp Outdated Show resolved Hide resolved

sycl/test-e2e/Graph/event_profiling_info.cpp Outdated Show resolved Hide resolved

Adds CUDA backend + immediate command-list

850ca7c

kbenzie reviewed Jan 11, 2024

View reviewed changes

sycl/plugins/unified_runtime/CMakeLists.txt Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/sycl' into command-buffer-profil…

50dd1b8

…ing-support

EwanC temporarily deployed to WindowsCILock January 11, 2024 15:52 — with GitHub Actions Inactive

EwanC temporarily deployed to WindowsCILock January 11, 2024 16:20 — with GitHub Actions Inactive

kbenzie marked this pull request as ready for review January 11, 2024 17:11

kbenzie requested a review from a team as a code owner January 11, 2024 17:11

kbenzie approved these changes Jan 11, 2024

View reviewed changes

EwanC approved these changes Jan 12, 2024

View reviewed changes

Merge branch 'sycl' into command-buffer-profiling-support

f2841b2

mfrancepillois temporarily deployed to WindowsCILock January 12, 2024 16:52 — with GitHub Actions Inactive

mfrancepillois temporarily deployed to WindowsCILock January 12, 2024 18:15 — with GitHub Actions Inactive

steffenlarsen approved these changes Jan 16, 2024

View reviewed changes

sycl/source/detail/event_impl.cpp Outdated Show resolved Hide resolved

Update sycl/source/detail/event_impl.cpp

0c5aa70

Co-authored-by: Steffen Larsen <[email protected]>

mfrancepillois temporarily deployed to WindowsCILock January 17, 2024 10:01 — with GitHub Actions Inactive

mfrancepillois temporarily deployed to WindowsCILock January 17, 2024 10:27 — with GitHub Actions Inactive

reble reviewed Jan 17, 2024

View reviewed changes

sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved

reble approved these changes Jan 17, 2024

View reviewed changes

Update sycl/doc/design/CommandGraph.md

f207a48

Co-authored-by: Pablo Reble <[email protected]>

mfrancepillois had a problem deploying to WindowsCILock January 18, 2024 10:25 — with GitHub Actions Error

Updates image: typo

bd0f986

mfrancepillois temporarily deployed to WindowsCILock January 18, 2024 10:36 — with GitHub Actions Inactive

mfrancepillois temporarily deployed to WindowsCILock January 18, 2024 10:59 — with GitHub Actions Inactive

sarnex merged commit b04f894 into intel:sycl Jan 18, 2024

EwanC mentioned this pull request Jan 31, 2024

Implement querying the event returned by a graph submission for profiling information reble/llvm#96

Closed

EwanC mentioned this pull request Mar 26, 2024

[SYCL][Graph][Doc] Remove outdated limitation from spec #13163

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][Graph] Add support for enabling Command-Buffer profiling #11324

[SYCL][Graph] Add support for enabling Command-Buffer profiling #11324

Uh oh!

mfrancepillois commented Sep 27, 2023 •

edited

Loading

Uh oh!

EwanC commented Oct 2, 2023

Uh oh!

tovinkere commented Oct 3, 2023

Uh oh!

EwanC left a comment

Uh oh!

Uh oh!

Uh oh!

kbenzie left a comment

Uh oh!

Uh oh!

aarongreig commented Jan 12, 2024

Uh oh!

steffenlarsen left a comment

Uh oh!

Uh oh!

Uh oh!

reble left a comment

Uh oh!

EwanC commented Jan 18, 2024

Uh oh!

Uh oh!

[SYCL][Graph] Add support for enabling Command-Buffer profiling #11324

[SYCL][Graph] Add support for enabling Command-Buffer profiling #11324

Uh oh!

Conversation

mfrancepillois commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EwanC commented Oct 2, 2023

Uh oh!

tovinkere commented Oct 3, 2023

Uh oh!

EwanC left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kbenzie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aarongreig commented Jan 12, 2024

Uh oh!

steffenlarsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

reble left a comment

Choose a reason for hiding this comment

Uh oh!

EwanC commented Jan 18, 2024

Uh oh!

Uh oh!

mfrancepillois commented Sep 27, 2023 •

edited

Loading