[SYCL][ESIMD] Add supported versions of raw_send APIs #11333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some design decisions I made here:
Only add the versions with must-be-constant arguments as template parameters. The original versions had them as runtime parameters and it worked some times, but if the compiler can't optimize it, it will fail. It seems sane to me to only add the versions which are guaranteed to be correct.
Replace
eot
/sendc
arguments with enums, we discussed this one and is hopefully not controversialMove the intrinsics to supported and call the supported intrinsics in the experiemntal code just to prevent code duplication
Also, the
histrogram_raw_send
test doesn't even compile in HEAD, we didn't catch it because it requires gen9 and we don't test that anymore. It was doing something insane withexecSize
and once we made mask len == exec size it broke. They aren't even using the mask so just remove it to fix the test.Manually verified both modified tests pass.