[SYCL] Report an error when SYCL_DEVICE_TYPE is set incorrectly.

[glyons-intel]

Signed-off-by: Gail Lyons [email protected]

[AGindinson]

Minor comments:

[glyons-intel]

@AGindinson & @bader
I did combine both the positive and negative tests into one file, as requested.
Gail

[AlexeySachkov]

Interesting... I don't expect clang-format to indent namespace here.
I thought that it's fixed by intel#1121.
@AlexeySachkov, any ideas what could be the problem? Old clang-format version?

Most likely. Corresponding feature was added to clang-format just ~8 month ago: https://reviews.llvm.org/D37813

[glyons-intel]

This is the version of clang-format that I am using:

% clang-format --version
clang-format version 11.0.0 (https://github.com/glyons-intel/llvm 41b73bec8453bc22e03dccb27be9472072770290)

I invoked it like this:
clang-format --style=llvm force_device.cpp > new_force_device.cpp

[bader]

This is the version of clang-format that I am using:

% clang-format --version
clang-format version 11.0.0 (https://github.com/glyons-intel/llvm 41b73bec8453bc22e03dccb27be9472072770290)

I invoked it like this:
clang-format --style=llvm force_device.cpp > new_force_device.cpp

Could you remove --style=llvm, please?
I think it's the problem. It disables the configuration we did for the project here: https://github.com/intel/llvm/blob/sycl/sycl/.clang-format.

[glyons-intel]

Yes, that made a difference.
I think I read about using --style=llvm in the standard clang-format documentation.
I will update my patch.

[bader]

LGTM. Thanks!