Skip to content

[UR][L0] Check Global Mem Size as Limit for Free Memory #11379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Oct 2, 2023

No description provided.

@abagusetty
Copy link
Contributor

Just curious, would there be cases when L0's free memory reporting exceeds global-memory

@nrspruit
Copy link
Contributor Author

nrspruit commented Oct 3, 2023

Just curious, would there be cases when L0's free memory reporting exceeds global-memory

The physical memory available can be more than the global memory reported. Global memory size is the total size of memory - an approximation of memory used for internal driver purposes. Because of this, the free memory reported can be larger than the global memory, which is why we need to get the min of free memory and global memory as the size to return to a user when querying free memory size to reduce chances of an out of memory condition by the user.

@nrspruit nrspruit temporarily deployed to WindowsCILock October 10, 2023 19:46 — with GitHub Actions Inactive
@nrspruit nrspruit temporarily deployed to WindowsCILock October 10, 2023 20:08 — with GitHub Actions Inactive
@kbenzie
Copy link
Contributor

kbenzie commented Dec 6, 2023

Superceed by #12101.

@kbenzie kbenzie closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants