[SYCL] Disable RTTI for SYCL device compilation #11411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not support RTTI in kernel code. Do not emit type info during SYCL device compilation. This aligns SYCL with other offloading targets liek CUDA.
elizabethandrews
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
elizabethandrews
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
ping @premanandrao @smanna12 |
premanandrao
approved these changes
Oct 9, 2023
It just checked IR for vtable and typeinfo. We've removed type info and since we already have another test checking vtable IR, I removed this test since it was superflous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not support RTTI in kernel code. Do not emit type info during SYCL device compilation.
This aligns SYCL with other offloading targets like CUDA.