[UR][L0] Add support for passing device list to urProgramBuild/Link/Compile #11464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrspruit
changed the title
jandres742
reviewed
Oct 7, 2023
nrspruit
force-pushed
the
fixprogrambuild_updated
branch
from
5f626dc to
ca899fa
Compare
nrspruit
force-pushed
the
fixprogrambuild_updated
branch
2 times, most recently
from
3cc5f53 to
59733a6
Compare
…ompile piProgramBuild receives a list of devices, while urProgramBuild does not. This produces a series of issues when a UR program needs to be created for a specific device. So define a new API, called urProgramBuildExp to pass this list. Requires related patch in Unified Runtime Adapters here: oneapi-src/unified-runtime#934 Signed-off-by: Spruit, Neil R <[email protected]>
nrspruit
force-pushed
the
fixprogrambuild_updated
branch
from
59733a6 to
55a872f
Compare
|
@nrspruit oneapi-src/unified-runtime#934 has been merged so I've updated the UR tag and merged in the latest sycl branch changes. |
callumfare
approved these changes
Nov 21, 2023
kbenzie
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
I think I know why the checks are failing. Working on a fix. |
kbenzie
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please merge. |
17 tasks
callumfare
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Dec 18, 2023
…ompile (intel#11464) piProgramBuild receives a list of devices, while urProgramBuild does not. This produces a series of issues when a UR program needs to be created for a specific device. So define a new API, called urProgramBuildExp to pass this list. Requires related patch in Unified Runtime Adapters here: oneapi-src/unified-runtime#934 --------- Signed-off-by: Spruit, Neil R <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
piProgramBuild receives a list of devices, while urProgramBuild does not. This produces a series of issues when a UR program needs to be created for a specific device.
So define a new API, called urProgramBuildExp to pass this list.
Requires related patch in Unified Runtime Adapters here: oneapi-src/unified-runtime#934