[SYCL] ext kernel compiler #11517

cperkinsintel · 2023-10-12T04:42:19Z

This is the implementation for the new "Kernel Compiler" which will replace the Online Compiler.
Its pending spec is here: #11331

…ore. But, most importantly, the PI which is the biggest hurdle this will face and is my next target. Better get a running start.

… new property list stuff in, error checking, testing, and other to-do.

againull

Looks good to me, but I would prefer extension doc to be merged first and explicit approval in this PR from @gmlueck ,

gmlueck · 2023-11-09T22:22:58Z

sycl/test-e2e/KernelCompiler/kernel_compiler.cpp

+  int InputArray[N] = {0, 1, 2, 3};
+  int OutputArray[N] = {};


Suggested change

int InputArray[N] = {0, 1, 2, 3};

int OutputArray[N] = {};

cl_int InputArray[N] = {0, 1, 2, 3};

cl_int OutputArray[N] = {};

I recently expanded the extension specification to list the rules for legal parameter types, and I realized that we should really be using the OpenCL types like cl_int on the host. Check the types of your other kernel arguments too. See 41945cd for the details I added to the spec.

Hi @cperkinsintel,

I saw that you requested re-review of this PR. Please see this comment I made above yesterday.

Sorry about that @gmlueck , I didn't mean to ping you last night. I made the change now, using sycl::cl_int (etc) instead of int and friends in both the kernel_compiler.cpp test and the ocl_capabilities.cpp one.

I think I saw in the recent spec update that the example has #include <OpenCL/opencl.h> to get the OpenCL types, but that shouldn't be necessary, correct? They are exposed in the sycl namespace. Let me know if I'm confusing anything.

Actually, the "cl_" types are not supposed to be exposed in the sycl namespace. If our headers are doing that, it is a bug.

The SYCL OpenCL backend interop spec does say these types are available in the sycl::opencl namespace, but that's only if the implementation supports the OpenCL backend. (DPC++ does, but that's not true for all SYCL implementations.) It's safest to include <OpenCL/opencl.h> and then use the "cl_" types in the root namespace.

Thanks. Updated

Don't you also need #include <OpenCL/opencl.h>?

sycl/test-e2e/KernelCompiler/kernel_compiler.cpp

gmlueck · 2023-11-13T20:08:58Z

@cperkinsintel: Can you also move the extension specifications to "experimental" as part of this PR? I believe both of these extensions are implemented by your PR, so they should both be moved:

In addition to moving them to the "experimental" directory, please also change the Status section to use the text from the extension template.

againull · 2023-11-14T00:50:24Z

@cperkinsintel There is a post-commit failure after this PR: https://github.com/intel/llvm/actions/runs/6857049804/job/18645408635

Could you please help to fix that?

This patch fixes a regression caused by refactoring of `split_string` function in #11517. The regression is the following: the delimiter is a space, input string is `"A B C "` - which has a space at the end. Before #11517 `split_string` returned `{"A", "B", "C"}` but with #11517 it returns `{"A", "B", "C", ""}`. This regression affects multiple CTS tests, verified the fix locally, and also unit tests for `split_string` function were added to this patch. This log shows that one of the unit tests failed before applying the fix: https://github.com/intel/llvm/actions/runs/6974175043/job/18979466747#step:11:372. With the fix it passes. Fixes #11996

cperkinsintel added 15 commits September 26, 2023 12:11

who doesn't love enums?

543848c

create_kernel_bundle_from_source()

0164468

is_source_kernel_bundle_supported plus interim

fc8b897

OCL SpirV gen. Need templating, wrapping for language dispatch, and m…

0759ce9

…ore. But, most importantly, the PI which is the biggest hurdle this will face and is my next target. Better get a running start.

interim. UR sources have been moved.

ca4913b

attempt to leverage createSpirProgram(). Not working

26760b2

interim checkpoint, needs cleaning

dc9e934

except for the fact that the kernels are crashing, this is great!

c536da2

end to end kernel compilation and execution is working. Need to bring…

deb2663

… new property list stuff in, error checking, testing, and other to-do.

feature test and property list

6237594

properties problemties

0356b9d

property support

f27fcab

tests, constraints mid-work checkpoint

27005a6

constraints and test for such

514d0c1

linux ABI and supported check

e1cd7d9

cperkinsintel requested a review from gmlueck October 12, 2023 04:42

cperkinsintel added 4 commits October 12, 2023 10:30

resolved merge conflicts

c6b34ef

clang-format

4e6d986

clang-format?

ba85eca

clang-format humiliation

e15820b

cperkinsintel had a problem deploying to WindowsCILock October 12, 2023 19:48 — with GitHub Actions Failure

removed unneeded export b.c. win

8f44438

cperkinsintel had a problem deploying to WindowsCILock October 12, 2023 22:01 — with GitHub Actions Failure

cperkinsintel had a problem deploying to WindowsCILock October 12, 2023 22:29 — with GitHub Actions Failure

deprecation of online_compiler

6a4b127

cperkinsintel had a problem deploying to WindowsCILock October 12, 2023 23:00 — with GitHub Actions Failure

windows symbols

c4bd305

cperkinsintel temporarily deployed to WindowsCILock October 12, 2023 23:32 — with GitHub Actions Inactive

cperkinsintel had a problem deploying to WindowsCILock October 13, 2023 00:15 — with GitHub Actions Failure

overlooked feature test

45ef189

cperkinsintel temporarily deployed to WindowsCILock November 8, 2023 04:01 — with GitHub Actions Inactive

cperkinsintel temporarily deployed to WindowsCILock November 8, 2023 04:29 — with GitHub Actions Inactive

test requirement fix

1ebedbf

cperkinsintel temporarily deployed to WindowsCILock November 8, 2023 20:08 — with GitHub Actions Inactive

cperkinsintel temporarily deployed to WindowsCILock November 8, 2023 21:35 — with GitHub Actions Inactive

againull self-requested a review November 9, 2023 19:50

againull approved these changes Nov 9, 2023

View reviewed changes

gmlueck reviewed Nov 9, 2023

View reviewed changes

cperkinsintel requested a review from gmlueck November 10, 2023 01:36

cperkinsintel added 2 commits November 10, 2023 09:12

cl types

8de6bdf

resolve merge conflicts

4ba2f3f

cperkinsintel temporarily deployed to WindowsCILock November 10, 2023 18:01 — with GitHub Actions Inactive

cperkinsintel temporarily deployed to WindowsCILock November 10, 2023 18:54 — with GitHub Actions Inactive

gmlueck reviewed Nov 10, 2023

View reviewed changes

sycl/test-e2e/KernelCompiler/kernel_compiler.cpp Outdated Show resolved Hide resolved

reviewer feedback - ensure test is also run by L0

010479a

cperkinsintel temporarily deployed to WindowsCILock November 13, 2023 18:05 — with GitHub Actions Inactive

JackAKirk mentioned this pull request Nov 13, 2023

[SYCL][CUDA][HIP] Fix enable-global-offset flag #11674

Merged

cperkinsintel temporarily deployed to WindowsCILock November 13, 2023 18:33 — with GitHub Actions Inactive

cperkinsintel added 2 commits November 13, 2023 12:44

Merge branch 'sycl' into cperkins-ext_kernel_compiler

988305f

moved specs to experimental and updated their status

ee77b72

cperkinsintel requested a review from a team as a code owner November 13, 2023 20:49

cperkinsintel temporarily deployed to WindowsCILock November 13, 2023 20:51 — with GitHub Actions Inactive

gmlueck approved these changes Nov 13, 2023

View reviewed changes

cperkinsintel temporarily deployed to WindowsCILock November 13, 2023 21:24 — with GitHub Actions Inactive

againull merged commit 096676e into intel:sycl Nov 13, 2023

hvdijk mentioned this pull request Nov 23, 2023

#11517 introduces "Attempting to use a built-in kernel. They are not fully supported" errors in SYCL-CTS #11996

Closed

dm-vodopyanov mentioned this pull request Nov 23, 2023

[SYCL] Fix regression introduced in https://github.com/intel/llvm/pull/11517 #12002

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL] ext kernel compiler #11517

[SYCL] ext kernel compiler #11517

Uh oh!

cperkinsintel commented Oct 12, 2023

Uh oh!

againull left a comment

Uh oh!

gmlueck Nov 9, 2023

Uh oh!

gmlueck Nov 10, 2023

Uh oh!

cperkinsintel Nov 10, 2023

Uh oh!

gmlueck Nov 10, 2023

Uh oh!

cperkinsintel Nov 13, 2023

Uh oh!

gmlueck Nov 13, 2023

Uh oh!

Uh oh!

gmlueck commented Nov 13, 2023

Uh oh!

againull commented Nov 14, 2023

Uh oh!

Uh oh!

[SYCL] ext kernel compiler #11517

[SYCL] ext kernel compiler #11517

Uh oh!

Conversation

cperkinsintel commented Oct 12, 2023

Uh oh!

againull left a comment

Choose a reason for hiding this comment

Uh oh!

gmlueck Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

gmlueck Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

cperkinsintel Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

gmlueck Nov 10, 2023

Choose a reason for hiding this comment

Uh oh!

cperkinsintel Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!

gmlueck Nov 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gmlueck commented Nov 13, 2023

Uh oh!

againull commented Nov 14, 2023

Uh oh!

Uh oh!