[UR][L0] Correctly wait on barrier on urEnqueueEventsWaitWithBarrier #11541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandres742
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jandres742
force-pushed
the
fixwaitbarrierwithevent
branch
from
4c86f07 to
3574762
Compare
jandres742
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@jandres742 Testing is failing because 780c96ea22d8d22e8749be3741bd4eeff5c5cc8a commit is in your fork and not in the original repo: https://github.com/oneapi-src/unified-runtime.git |
jandres742
force-pushed
the
fixwaitbarrierwithevent
branch
from
3574762 to
e82c572
Compare
jandres742
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jandres742
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jandres742
force-pushed
the
fixwaitbarrierwithevent
branch
from
e82c572 to
5adffe3
Compare
jandres742
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jandres742
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jandres742
force-pushed
the
fixwaitbarrierwithevent
branch
from
5adffe3 to
2eb36a7
Compare
jandres742
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jandres742
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jandres742
force-pushed
the
fixwaitbarrierwithevent
branch
from
2eb36a7 to
aeb6c15
Compare
jandres742
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jandres742
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jandres742
force-pushed
the
fixwaitbarrierwithevent
branch
2 times, most recently
from
00f0551 to
1dc159d
Compare
jandres742
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jandres742
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jandres742
force-pushed
the
fixwaitbarrierwithevent
branch
from
1dc159d to
a6b80bd
Compare
jandres742
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jandres742
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@smaslov-intel : please take a look at the changes in the test. Related UR PR: github.com/oneapi-src/unified-runtime/pull/962 |
jandres742
force-pushed
the
fixwaitbarrierwithevent
branch
from
a6b80bd to
8de5a7f
Compare
jandres742
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
When event list is null, a barrier is still needed for all previous commands if profiling is enabled, so fix it. Signed-off-by: Jaime Arteaga <[email protected]>
jandres742
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Dec 8, 2023
|
@intel/llvm-gatekeepers please merge. |
17 tasks
callumfare
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Dec 18, 2023
…ntel#11541) When event list is null, a barrier is still needed for all previous commands, so fix it. --------- Signed-off-by: Jaime Arteaga <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When event list is null, a barrier is still needed for all previous commands, so fix it.