Skip to content

[SYCL][Graph][L0] Reset L0 events for UR sync-points #11553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 27, 2023
Merged

[SYCL][Graph][L0] Reset L0 events for UR sync-points #11553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
be0603c
[SYCL][Graph] Reset L0 events for UR sync-points
EwanC Oct 16, 2023
68e2d95
[SYCL][Graph] Update UR command-buffer diagram
EwanC Oct 17, 2023
de47a50
Merge branch 'sycl' into ewan/L0_sync_point_event_reset
EwanC Oct 18, 2023
9581582
Merge branch 'sycl' into ewan/L0_sync_point_event_reset
EwanC Oct 19, 2023
9391f9d
Merge branch 'sycl' into ewan/L0_sync_point_event_reset
EwanC Oct 23, 2023
9cba3a7
Merge branch 'sycl' into ewan/L0_sync_point_event_reset
EwanC Oct 26, 2023
c3975aa
Update UR tag comment
EwanC Oct 26, 2023
ff8b72c
Merge branch 'sycl' into ewan/L0_sync_point_event_reset
EwanC Oct 26, 2023
bde2014
Prefer SVG to JPG for documentation images
EwanC Oct 26, 2023
3e4a613
Try SVG image again
EwanC Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sycl/doc/design/CommandGraph.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ created on UR command-buffer enqueue.

There is also a *WaitEvent* used by the `ur_exp_command_buffer_handle_t` class
in the prefix to wait on any dependencies passed in the enqueue wait-list.
This WaitEvent is reset at the end of the suffix, along with reset commands
to reset the L0 events used to implement the UR sync-points back to the
non-signaled state.

![L0 command-buffer diagram](images/L0_UR_command-buffer.svg)

Expand Down
18 changes: 1 addition & 17 deletions sycl/doc/design/images/L0_UR_command-buffer.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 6 additions & 6 deletions sycl/plugins/unified_runtime/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
include(FetchContent)

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
# commit cf26de283a1233e6c93feb085acc10c566888b59
# Merge: 3a3aae38 2fd9dea2
# commit: 7c8617b3710736db642585fe310a64e19e059d2e
# Merge: 20d4f49 9a13af
# Author: Kenneth Benzie (Benie) <[email protected]>
# Date: Wed Oct 25 10:36:48 2023 +0100
# Merge pull request #940 from Naghasan/victor/kernel-fusion-amd
# [UR][HIP] Enable kernel finalization using comgr
set(UNIFIED_RUNTIME_TAG cf26de283a1233e6c93feb085acc10c566888b59)
# Date: Thu Oct 26 10:20:03 2023 +0100
# Merge pull request #965 from Bensuo/ewan/L0_internal_event_fix
# [Command-buffer][L0] Reset sync-point events
set(UNIFIED_RUNTIME_TAG 7c8617b3710736db642585fe310a64e19e059d2e)

if(SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO)
set(UNIFIED_RUNTIME_REPO "${SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO}")
Expand Down