Skip to content

[NFC][Devops] CODEOWNERS: update matrix ownership to team instead of induvials #11571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

stdale-intel
Copy link
Contributor

When possible, we should have teams owning segments of code when there is multiple owners involved. Switching matrix stuff to follow this pattern

@stdale-intel
Copy link
Contributor Author

Codeowner file showing errors since team was just created. That will be resolved once team fully propagates through system (https://github.com/orgs/intel/teams/sycl-matrix-reviewers).

Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sycl/test/matrix @dkhaldi @YuriPlyakhin @yubingex007-a11y
sycl/include/sycl/ext/oneapi/matrix/ @intel/sycl-matrix-reviewers
sycl/test-e2e/Matrix @intel/sycl-matrix-reviewers
sycl/test/matrix @intel/sycl-matrix-reviewers
Copy link
Contributor

@dm-vodopyanov dm-vodopyanov Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stdale-intel Github highlights a warning, is it ok?

image

Copy link
Contributor Author

@stdale-intel stdale-intel Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can take a day or two for the new team to fully propagate through the system, until then the CODEOWNER file will show these errors.

@stdale-intel
Copy link
Contributor Author

@intel/dpcpp-devops-reviewers issue with CODEOWNERS file is now resolved and this should be ready for review.

@aelovikov-intel aelovikov-intel merged commit 4edeb64 into sycl Oct 19, 2023
@aelovikov-intel aelovikov-intel deleted the private/stewartt/updateCodeOwnersMatrixTeam branch October 19, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants